refactor/vue webpack aliases #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iaacosta
force-pushed
the
refactor/vue-alias
branch
from
e6f4c23 to
39cab74
Compare
rjherrera
reviewed
Jun 3, 2021
| @@ -8,6 +8,7 @@ Features: | |||
| Fixes: | |||
| - Explicitly install project specified node version in CircleCI build [#352](https://github.com/platanus/potassium/pull/352) | |||
| - Update marcel gem (shrine's mime type analyzer) to avoid mimemagic dependency [#357](https://github.com/platanus/potassium/pull/357) | |||
| - Add Vue alias in the Webpacker config to avoid strange behaviors of external packages [#360](https://github.com/platanus/potassium/pull/358) | |||
|
This was already implemented on the Typescript + Vue 3 upgrade, so I'm gonna close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Rails uses the es-module version of Vue when installing it with
rails webpacker:install, which resolves to thevue/dist/vue.esm.jsfile.This brings some strange behaviors when using libraries that import the default Vue instance (just
vue).Changes
Add a Webpack alias inside the configuration to resolve all 'vue' imports to the es-module version.
Closes #359