Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop #337

Merged
merged 3 commits into from
Feb 4, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,19 @@ Performance/RedundantBlockCall:
Description: Use `yield` instead of `block.call`.
Reference: https://github.com/JuanitoFatas/fast-ruby#proccall-vs-yield-code
Enabled: false
Style/OptionalBooleanParameter:
Description: 'Use keyword arguments when defining method with boolean argument.'
Enabled: false
Lint/MissingSuper:
Description: >-
This cop checks for the presence of constructors and lifecycle callbacks
without calls to `super`'.
Enabled: false
Style/RedundantFileExtensionInRequire:
Description: >-
Checks for the presence of superfluous `.rb` extension in
the filename provided to `require` and `require_relative`.
Enabled: false
RSpec/MultipleExpectations:
Max: 5
RSpec/NestedGroups:
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
# Changelog

## Unreleased

Features:
- Add Google Tag Manager [#326](https://github.com/platanus/potassium/pull/326)
- Update rubocop and rubocop-rspec for potassium and generated projects [#337](https://github.com/platanus/potassium/pull/337)

## 6.1.0

Features:
Expand Down
13 changes: 13 additions & 0 deletions lib/potassium/assets/.rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,19 @@ Performance/RedundantBlockCall:
Description: Use `yield` instead of `block.call`.
Reference: https://github.com/JuanitoFatas/fast-ruby#proccall-vs-yield-code
Enabled: false
Style/OptionalBooleanParameter:
Description: 'Use keyword arguments when defining method with boolean argument.'
Enabled: false
Lint/MissingSuper:
Description: >-
This cop checks for the presence of constructors and lifecycle callbacks
without calls to `super`'.
Enabled: false
Style/RedundantFileExtensionInRequire:
Description: >-
Checks for the presence of superfluous `.rb` extension in
the filename provided to `require` and `require_relative`.
Enabled: false
RSpec/MultipleExpectations:
Max: 5
RSpec/NestedGroups:
Expand Down
4 changes: 2 additions & 2 deletions lib/potassium/recipes/style.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ def install

def add_linters
gather_gems(:development, :test) do
gather_gem 'rubocop', '~> 0.82.0'
gather_gem 'rubocop', Potassium::RUBOCOP_VERSION
gather_gem 'rubocop-performance'
gather_gem 'rubocop-rails'
gather_gem 'rubocop-rspec'
gather_gem 'rubocop-rspec', Potassium::RUBOCOP_RSPEC_VERSION
end
run 'bin/yarn add --dev stylelint eslint eslint-plugin-import'
run 'bin/yarn add --dev eslint-plugin-vue' if selected?(:front_end, :vue)
Expand Down
3 changes: 2 additions & 1 deletion lib/potassium/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ module Potassium
VERSION = "6.1.0"
RUBY_VERSION = "2.7.0"
RAILS_VERSION = "~> 6.0.2"
RUBOCOP_VERSION = "~> 0.82.0"
RUBOCOP_VERSION = "~> 1.9"
RUBOCOP_RSPEC_VERSION = "~> 2.2"
POSTGRES_VERSION = "11.3"
MYSQL_VERSION = "5.7"
NODE_VERSION = "12"
Expand Down
2 changes: 1 addition & 1 deletion potassium.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "rubocop", Potassium::RUBOCOP_VERSION
spec.add_development_dependency "rubocop-performance"
spec.add_development_dependency "rubocop-rails"
spec.add_development_dependency "rubocop-rspec"
spec.add_development_dependency "rubocop-rspec", Potassium::RUBOCOP_RSPEC_VERSION
spec.add_runtime_dependency "gems", "~> 0.8"
spec.add_runtime_dependency "gli", "~> 2.12.2"
spec.add_runtime_dependency "inquirer", "~> 0.2"
Expand Down