feat(cors): use safer api/public-only CORS configuration #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldlsegovia
approved these changes
Feb 17, 2020
iobaixas
reviewed
Feb 17, 2020
rjherrera
force-pushed
the
cors-configuration
branch
from
541c8be to
a948012
Compare
iobaixas
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the default configuration bundled by the rack-cors recipe. As of today we were allowing requests from any origin to any resource, which is a very unsafe configuration. The new config only allows get requests to the urls under
publicand index/show/create/update/delete requests for urls underapi.closes #202