Improve specs performance #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
difernandez
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves test speeds by changing default test values for some recipes to none. This prevents unnecesary steps like
rails generate active_storage:installin every spec.This PR also adds 2 flags to the base template (which are passed to
rails new):--skip-bundle-installand--skip-webpack-install. This addresses #252 as the frontend recipe is now the only one that executesrails g webpack:install. This also avoids multiple calls ofbundle install, as it is called from one recipe.* P.S.: Webpacker gem is included by default by rails even with the
--skip-webpack-install(and it is a expected behaviour, as the flag is only intended to skip the:installsteps).closes #252, closes #257