Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidekiq scheduler #137

Merged
merged 4 commits into from
Jun 2, 2017
Merged

Sidekiq scheduler #137

merged 4 commits into from
Jun 2, 2017

Conversation

camilo9020
Copy link
Contributor

No description provided.

@camilo9020
Copy link
Contributor Author

[4p/13v] Deprecar clock, migrar a sidekiq y usar un thread de sidekiq como scheduler.

@felbalart felbalart changed the title Sidekiq scheduler [WIP] Sidekiq scheduler May 20, 2017
@camilo9020 camilo9020 force-pushed the sidekiq-scheduler branch from abd4e8e to 021d4f9 Compare May 26, 2017 20:09
@camilo9020 camilo9020 changed the title [WIP] Sidekiq scheduler Sidekiq scheduler May 26, 2017
@camilo9020 camilo9020 assigned blackjid and unassigned felbalart May 26, 2017
@blackjid
Copy link
Member

Hice una prueba y nunca me pregunto por el schedule

Which database are you using?: PostgreSQL
Do you want to use Devise for authentication? (required for ActiveAdmin): No
Which front-end framework are you going to use?: Vue
Which email service are you using?: None, thanks
Do you want to use Sidekiq for background job processing?: Yes
Do you need to report application errors with Sentry?: Yes
What is the main locale of your app?: es-CL (Chile)
Do you want to enable API support?: No
Do you want to use Draper to decorate models?: No
Do you want to use Paperclip for uploads?: No
Are you going to deploy to heroku? ([email protected]): No
Do you want to create the Github repository (https://github.com/platanus/test-side-sch) for this project?: No

monkeyci
monkeyci reviewed Jun 2, 2017
View reviewed changes
lib/potassium/recipes/background_processor.rb Outdated
else
info "Note: Emails should be sent on background jobs. We'll install sidekiq"
true
end
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end at 10, 14 is not aligned with if at 3, 15.

lib/potassium/recipes/background_processor.rb Outdated
answer(:background_processor) do
Ask.confirm("Do you want to use Sidekiq for background job processing?")
end
else
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align else with if.

lib/potassium/recipes/background_processor.rb Outdated

set(:background_processor, response.to_sym)
response = if selected?(:email_service, :none)
answer(:background_processor) do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not 1) spaces for indentation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yapo felipe!

@felbalart felbalart force-pushed the sidekiq-scheduler branch from 260b3fa to 94fdd9d Compare June 2, 2017 22:31
@felbalart
Copy link
Contributor

@blackjid solved
Listo para mergear

@blackjid blackjid merged commit bbea3dc into master Jun 2, 2017
@blackjid blackjid deleted the sidekiq-scheduler branch April 12, 2019 15:52
@difernandez difernandez mentioned this pull request Feb 11, 2021
Merged
@difernandez difernandez mentioned this pull request Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monkeyci monkeyci monkeyci left review comments

@blackjid blackjid blackjid left review comments

Assignees

@blackjid blackjid

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@camilo9020 @blackjid @felbalart @monkeyci