Skip to content

Commit

Permalink
Merge pull request #447 from platanus/update-node-20
Browse files Browse the repository at this point in the history
Update node 20
  • Loading branch information
difernandez authored Jul 3, 2023
2 parents 42de8eb + f561869 commit 00caf0f
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 4 deletions.
10 changes: 9 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
version: 2.1

ruby-image: &ruby-image cimg/ruby:2.7.4-node
ruby-image: &ruby-image cimg/ruby:2.7
env-vars: &env-vars
BUNDLE_JOBS: 4
RAILS_ENV: test
Expand Down Expand Up @@ -32,6 +32,14 @@ commands:
gem install bundler:2.1.4
bundle _2.1.4_ install
- run:
name: Install node and yarn
command: |
curl -sL https://deb.nodesource.com/setup_$(cat .node-version).x | sudo -E bash -
sudo apt-get install -y nodejs
curl -o- -sL https://yarnpkg.com/install.sh | bash
sudo ln -s $HOME/.yarn/bin/yarn /usr/local/bin/yarn
- save_cache:
key: potassium-vendor-bundle-{{ .Branch }}
paths:
Expand Down
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
14
20
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
Features
- Add environment variables module recipe [#435](https://github.com/platanus/potassium/pull/435)
- Run [Brakeman](https://brakemanscanner.org/) with reviewdog on CI [#440](https://github.com/platanus/potassium/pull/440)
- Update node to 20 [#447](https://github.com/platanus/potassium/pull/447)

Fixes
- Fix CircleCI config [#434](https://github.com/platanus/potassium/pull/434)
Expand Down
2 changes: 1 addition & 1 deletion lib/potassium/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ module Potassium
RUBOCOP_RSPEC_VERSION = "~> 2.2"
POSTGRES_VERSION = "11.3"
MYSQL_VERSION = "5.7"
NODE_VERSION = "14"
NODE_VERSION = "20"
TAILWINDCSS_VERSION = "^3.2.7"
POSTCSS_VERSION = "^8.4.21"
AUTOPREFIXER_VERSION = "^10.4.13"
Expand Down
2 changes: 1 addition & 1 deletion spec/features/node_spec.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
require "spec_helper"

RSpec.describe "Node" do
let(:version) { "14" }
let(:version) { Potassium::NODE_VERSION }

before(:all) do
drop_dummy_database
Expand Down

0 comments on commit 00caf0f

Please sign in to comment.