Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Jetty to 11.0.24 #349

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

rroesch1
Copy link
Contributor

No description provided.

@arnaudroques arnaudroques merged commit af30d63 into plantuml:master Feb 4, 2025
11 of 15 checks passed
arnaudroques added a commit that referenced this pull request Feb 4, 2025
@arnaudroques
Copy link
Contributor

Thanks for your contribution!

The change from <jetty.version>11.0.18</jetty.version> to <jetty.version>11.0.24</jetty.version> definitely makes sense.

However, it causes the CI to crash.

Do you have any ideas why? I'm a bit confused about this.

@rroesch1
Copy link
Contributor Author

rroesch1 commented Feb 5, 2025

Thanks for your contribution!

The change from <jetty.version>11.0.18</jetty.version> to <jetty.version>11.0.24</jetty.version> definitely makes sense.

However, it causes the CI to crash.

Do you have any ideas why? I'm a bit confused about this.

Looks like the jetty-runner module is broken …
The packaging process of jetty-runner breaks the Java SPI service configuration. Due to these invalid configuration files Jetty is unable to find and initialize org.eclipse.jetty.apache.jsp.JettyJasperInitializer.

I created #354 to get rid of all tests based on jetty-runner. There are already approriated replacements based on the jetty:run Maven goal.

@arnaudroques
Copy link
Contributor

Great!
Thanks again for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants