Be smarter with when to wrap in IIFE #37
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
The original setup was an introspection of both contents and ancestral tree, which led to wrapping things in IIFEs when not necessary. Because there is a (tiny, but present) cost to IIFEs vs pure inline logic, more intelligence is warranted.
Change
Modify
shouldWrapInClosure
to focus exclusively on the callsite's scope. This involves: