Issue 73 - primitive wrapper support #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planttheidea
commented
Apr 29, 2022
| @@ -87,6 +101,10 @@ export function createComparator(createIsEqual?: EqualityComparatorCreator): Equ | |||
| } | |||
| } | |||
|
|
|||
| if (a.valueOf !== valueOf || b.valueOf !== valueOf) { | |||
There was a problem hiding this comment.
This is the real change, doing SMZ if the valueOf differs from the default on all objects.
There was a problem hiding this comment.
As I'm sure you could tell from the issue I filed, I was really wondering how/where you could possibly detect this without a large number of checks. This is a clever solution, I like it a lot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change
Using primitive wrappers, such as
new Number(1)instead of just1provide false success comparisons, which can cause edge case incorrectness.Change
As the penultimate fallback for object comparisons, check if the
valueOfon the object is not the same as the standardObject.prototype.valueOf. For primitive wrappers (Number,Boolean, etc.), these are different, therefore allowing appropriate comparisons.Should fix #73 .