Require %CONTINUE% to process multiple map commands #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require %CONTINUE% to be used to continue processing map commands from different lines. This makes the map commands behave identically to the name commands.
Example:
Before the change, an armor matching the first line gets a purple 0 but a white map box. The name is taken from the first line, but the map condition is taken from the second (effectively).
After the change, an armor matching the first condition gets a purple 0 and a purple map box. The map condition and name are both taken from the same line.
To restore the original behavior:
It's ugly because it's probably not what you meant to do in the first place.
This will require changes to existing config files for anyone relying on all %MAP%, %border%, etc. actions to be processed regardless of %CONTINUE%. We could add a toggle for legacy support, but I think that it might be better to just force the use of %CONTINUE%.
Here's an example from @planqi's config:
This line needs continue:Correction: This scenario actually does not require CONTINUE because the first matching RUNE<13 line does not have any map commands (e.g., map, border, etc.). If this line had its own map commands already, the use of CONTINUE is required.