feat: ShouldAsk for Echo and Acknowledge
#358
Conversation
* Create an abstract class from which `Echo` and `Acknowledge` inherit * Add `should_ask` optional parameters * Only display a message if `should_ask` is `None` or `True`
Codecov Report
@@ Coverage Diff @@
## main #358 +/- ##
==========================================
+ Coverage 96.82% 97.18% +0.35%
==========================================
Files 6 6
Lines 347 355 +8
Branches 51 53 +2
==========================================
+ Hits 336 345 +9
+ Misses 9 8 -1
Partials 2 2
|
| @@ -16,7 +19,8 @@ adventure. These choices introduce diverging paths of interactions that may or m | |||
| ### Optional Questions | |||
|
|
|||
| The following is a basic example that has two optional questions that are not asked based on the answer to the first | |||
| question. | |||
| question. It also has an optional "echo" that is only displayed | |||
There was a problem hiding this comment.
| question. It also has an optional "echo" that is only displayed | |
| question. It also has an optional `Echo` that is only displayed |
Minor: I try to use the code formatting when referring to the classes by name.
There was a problem hiding this comment.
I wasn't referring to a class by name just as "two optional questions" wasn't referring to BasicQuestions. I used quotation marks because it is otherwise awkward to use echo as a noun here. I'll leave it as-is unless you have strong feelings (which it seems you don't).
There was a problem hiding this comment.
Hmm. Maybe something "It also has an optional message that is only...". That phrasing could remove the confusion I had.
| @@ -16,7 +19,8 @@ adventure. These choices introduce diverging paths of interactions that may or m | |||
| ### Optional Questions | |||
|
|
|||
| The following is a basic example that has two optional questions that are not asked based on the answer to the first | |||
| question. | |||
| question. It also has an optional "echo" that is only displayed | |||
There was a problem hiding this comment.
Hmm. Maybe something "It also has an optional message that is only...". That phrasing could remove the confusion I had.
Co-authored-by: Patrick Lannigan <[email protected]>
EchoandAcknowledgeinheritshould_askoptional parametersshould_askisNoneorTrueCloses #356