Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use “Actually” in class names #170

Closed
jab opened this issue Feb 8, 2020 · 1 comment · Fixed by #207
Closed

Do not use “Actually” in class names #170

jab opened this issue Feb 8, 2020 · 1 comment · Fixed by #207
Labels
enhancement New feature or request triaged Issue has been reviewed and should be pursued v2.0 breaking changes for next major release

Comments

@jab
Copy link

jab commented Feb 8, 2020

Does not improve clarity and adds bloat. We can deprecate in 1.x with an alias to the replacement, and drop completely in 2.0.
@jab jab mentioned this issue Feb 8, 2020
Open
@airstandley airstandley added enhancement New feature or request v2.0 breaking changes for next major release labels Mar 6, 2020
@RookieRick RookieRick added the triaged Issue has been reviewed and should be pursued label Jun 16, 2020
alidscott added a commit that referenced this issue Aug 11, 2020
@alidscott
Removing Actually from class names
47d8b4e 
https://jira.autodesk.com/browse/ACSBP-1521
#170
@alidscott alidscott mentioned this issue Aug 11, 2020
Merged
alidscott added a commit that referenced this issue Aug 11, 2020
@alidscott
Removing Actually from class names (#207)
119f7ff 
https://jira.autodesk.com/browse/ACSBP-1521
#170
@mjanes mjanes linked a pull request Sep 1, 2020 that will close this issue
Removing Actually from class names #207
Merged
@mjanes
Copy link
Contributor

mjanes commented Sep 1, 2020 •
edited
Loading

"Actually" has been removed from class names, but I see two comments referring to it. Will clean.

Nevermind, the remaining instances of "actually" are only in change logs, or not referring to class names.

@mjanes mjanes closed this as completed Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request triaged Issue has been reviewed and should be pursued v2.0 breaking changes for next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing Actually from class names plangrid/flask-rebar
4 participants
@jab @mjanes @airstandley @RookieRick