Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to swiper and more. #59

Merged
merged 1 commit into from
Jun 22, 2024
Merged

updates to swiper and more. #59

merged 1 commit into from
Jun 22, 2024

Conversation

plang-psm
Copy link
Owner

@plang-psm plang-psm commented Jun 22, 2024

Issue Overview:

Swiper UI needs to be adjusted for a cleaner ui

Issue: #

What is the context for the changes? Are there any?

UI, accessibility changes.

Changes made:

Include a list that briefly describes what changes you made in this PR.

  • Adjust size of swiper and the images inside
  • Restructure files
  • Added hover effect on home carousels
  • Removed show password from login
  • Add auto complete on login/sign up forms

Rationale behind the change:

Why did you choose to make these changes? Were there any trade-offs you had to consider?

Improve app UI, and accessibility

Test plan:

How did you confirm these changes were safe to ship to production?

localhost

Screenshot (optional):

N/A

Quality check:

Do your changes follow best practices (SOLID)?

Yes

Are there any console.logs, unused code, or debuggers?

No.

Reread what you filled out and make sure it makes sense. Any extra context?

Yes.

Copy link

vercel bot commented Jun 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
popflix ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2024 7:28pm

@plang-psm plang-psm merged commit f7e889d into main Jun 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant