Vtctld Test cases in Go using cluster #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arindamnayak
commented
Oct 31, 2019
| @@ -96,3 +96,8 @@ func (client *gRPCVtctlClient) Close() { | |||
| func init() { | |||
| vtctlclient.RegisterFactory("grpc", gRPCVtctlClientFactory) | |||
| } | |||
|
|
|||
| // NewClient instantiates a vtctl client instance from address | |||
| func NewClient(address string) (vtctlclient.VtctlClient, error) { | |||
There was a problem hiding this comment.
@deepthi , I need to test vtctl using grpc, but there was no way to get instance of vtctl, that is why I added this public method. Let me know if there is some other to achieve this.
There was a problem hiding this comment.
Can't you use the VtctlClientProcess that you have already added? That uses grpc.
There was a problem hiding this comment.
Yes, I have added test using VtctlClientProcess , but since python testcase uses both way of testing i.e. vtctlclient and grpc connection to vtctl, I thought of doing it both way.
There was a problem hiding this comment.
I don't think that is necessary. Some of what the python test is doing is probably to test the python grpc client itself.
There was a problem hiding this comment.
I have removed that in last commit, please review again.
Signed-off-by: Arindam Nayak <[email protected]>
arindamnayak
force-pushed
the
tal_test_vtctld
branch
from
3375b98 to
926b21a
Compare
deepthi
reviewed
Oct 31, 2019
| @@ -187,6 +188,7 @@ func (cluster *LocalProcessCluster) StartKeyspace(keyspace Keyspace, shardNames | |||
| cluster.Hostname, | |||
| cluster.TmpDirectory, | |||
| cluster.VtTabletExtraArgs) | |||
| tablet.Alias = tablet.vttabletProcess.TabletPath | |||
There was a problem hiding this comment.
when does the TabletPath get set and what is it set to? Alias is usually of the form cell1-00000001 (cell + uid).
There was a problem hiding this comment.
Yes, you are right, tabletpath is set as cell1-000000001 here.
Signed-off-by: Arindam Nayak <[email protected]>
Signed-off-by: Arindam Nayak <[email protected]>
deepthi
approved these changes
Nov 5, 2019
ajeetj
changed the title
arindamnayak
added a commit
that referenced
this pull request
Nov 25, 2019
* converted vtctld_test.py to go Signed-off-by: Arindam Nayak <[email protected]>
ajeetj
pushed a commit
that referenced
this pull request
Dec 3, 2019
* converted vtctld_test.py to go Signed-off-by: Arindam Nayak <[email protected]>
ajeetj
pushed a commit
that referenced
this pull request
Dec 6, 2019
* converted vtctld_test.py to go Signed-off-by: Arindam Nayak <[email protected]> Signed-off-by: Arindam Nayak <[email protected]>
arindamnayak
added a commit
that referenced
this pull request
Dec 6, 2019
* converted vtctld_test.py to go Signed-off-by: Arindam Nayak <[email protected]> Signed-off-by: Arindam Nayak <[email protected]>
arindamnayak
added a commit
that referenced
this pull request
Dec 10, 2019
* converted vtctld_test.py to go Signed-off-by: Arindam Nayak <[email protected]> Signed-off-by: Arindam Nayak <[email protected]>
arindamnayak
added a commit
that referenced
this pull request
Dec 10, 2019
* converted vtctld_test.py to go Signed-off-by: Arindam Nayak <[email protected]> Signed-off-by: Arindam Nayak <[email protected]>
ajeetj
added a commit
that referenced
this pull request
Dec 20, 2019
* Rebase test_master with latest Cluster code (#22) * pick latest fix from cluster_for_test Signed-off-by: Arindam Nayak <[email protected]> * Tabletmanager2 test cases in GO using cluster (#23) * tabletmanager lock unlock table test case Signed-off-by: Ajeet jain <[email protected]> * Vtctld Test cases in Go using cluster (#25) * converted vtctld_test.py to go Signed-off-by: Arindam Nayak <[email protected]> * Converted schema.py testcase (#26) * migrated one of testcase from schema.py to schema_test.go Signed-off-by: Arindam Nayak <[email protected]> * Tablet Manager test cases in Go using cluster (#27) * converted tabletmanager test cases to go Signed-off-by: Ajeet jain <[email protected]> * Converted keyspace test to go (#28) * ported testcase of keyspace_test.py Signed-off-by: Arindam Nayak <[email protected]> * Converted sharded test from py to go (#29) * Converted sharded test from py to go Signed-off-by: Arindam Nayak <[email protected]> * initial commit for sharding test Signed-off-by: Arindam Nayak <[email protected]> * added reconciliation assert Signed-off-by: Arindam Nayak <[email protected]> * added insert and stream replication Signed-off-by: Arindam Nayak <[email protected]> * added rest assertions including migrateservedtypes Signed-off-by: Arindam Nayak <[email protected]> * completed remaining assertions and fixed non-workings Signed-off-by: Arindam Nayak <[email protected]> * converted to v3 way of resharding Signed-off-by: Arindam Nayak <[email protected]> * restructured the testcases Signed-off-by: Arindam Nayak <[email protected]> * added testcase with bytes as sharding key type Signed-off-by: Arindam Nayak <[email protected]> * Rebase test_master with latest Cluster code (#22) * pick latest fix from cluster_for_test Signed-off-by: Arindam Nayak <[email protected]> * Tabletmanager2 test cases in GO using cluster (#23) * tabletmanager lock unlock table test case Signed-off-by: Ajeet jain <[email protected]> * Vtctld Test cases in Go using cluster (#25) * converted vtctld_test.py to go Signed-off-by: Arindam Nayak <[email protected]> * Converted schema.py testcase (#26) * migrated one of testcase from schema.py to schema_test.go Signed-off-by: Arindam Nayak <[email protected]> * Tablet Manager test cases in Go using cluster (#27) * converted tabletmanager test cases to go Signed-off-by: Ajeet jain <[email protected]> * Converted keyspace test to go (#28) * ported testcase of keyspace_test.py Signed-off-by: Arindam Nayak <[email protected]> * Converted sharded test from py to go (#29) * Converted sharded test from py to go Signed-off-by: Arindam Nayak <[email protected]> * Added testcase for mysqlctl process Signed-off-by: saurabh <[email protected]> * removed unused variables Signed-off-by: saurabh <[email protected]> * removing comment Signed-off-by: saurabh <[email protected]> * addressed review comments Signed-off-by: saurabh <[email protected]> * removed cleandir flag from vttablet teardown Signed-off-by: Arindam Nayak <[email protected]> * added v3 sharding test Signed-off-by: Arindam Nayak <[email protected]> * vtgate buffer testcase migrated in go Signed-off-by: saurabh <[email protected]> * inital code for resharding Signed-off-by: Ajeet jain <[email protected]> * completed the cluster code Signed-off-by: Ajeet jain <[email protected]> * more progress Signed-off-by: Ajeet jain <[email protected]> * pull graceful shutdown code Signed-off-by: Ajeet jain <[email protected]> * added fe more cases in resharding_test.go Signed-off-by: Ajeet jain <[email protected]> * fixed merge issues Signed-off-by: Ajeet jain <[email protected]> * running mysql in parallel mode and fe more assertions Signed-off-by: Ajeet jain <[email protected]> * used rbr mysql mode Signed-off-by: Arindam Nayak <[email protected]> * almost finished with reshading v2 version Signed-off-by: Ajeet jain <[email protected]> * Rebase test_master with latest Cluster code (#22) * pick latest fix from cluster_for_test Signed-off-by: Arindam Nayak <[email protected]> * Tabletmanager2 test cases in GO using cluster (#23) * tabletmanager lock unlock table test case Signed-off-by: Ajeet jain <[email protected]> * Vtctld Test cases in Go using cluster (#25) * converted vtctld_test.py to go Signed-off-by: Arindam Nayak <[email protected]> * Converted schema.py testcase (#26) * migrated one of testcase from schema.py to schema_test.go Signed-off-by: Arindam Nayak <[email protected]> * Tablet Manager test cases in Go using cluster (#27) * converted tabletmanager test cases to go Signed-off-by: Ajeet jain <[email protected]> * Converted keyspace test to go (#28) * ported testcase of keyspace_test.py Signed-off-by: Arindam Nayak <[email protected]> * Converted sharded test from py to go (#29) * Converted sharded test from py to go Signed-off-by: Arindam Nayak <[email protected]> * Added testcase for mysqlctl process Signed-off-by: saurabh <[email protected]> * removed unused variables Signed-off-by: saurabh <[email protected]> * removing comment Signed-off-by: saurabh <[email protected]> * addressed review comments Signed-off-by: saurabh <[email protected]> * removed cleandir flag from vttablet teardown Signed-off-by: Arindam Nayak <[email protected]> * vtgate buffer testcase migrated in go Signed-off-by: saurabh <[email protected]> * changed code to use v3 way of sharding Signed-off-by: Arindam Nayak <[email protected]> * converted to v3 way Signed-off-by: Ajeet jain <[email protected]> * added multi split diff and multi sharding Signed-off-by: Arindam Nayak <[email protected]> * converted to v3 way Signed-off-by: Ajeet jain <[email protected]> * TabletManager remaining test cases TabletManager remaining test cases in GO Signed-off-by: Ajeet jain <[email protected]> * moved sql start to non-blocking mode (#35) * moved sql start to non-blocking mode Signed-off-by: Arindam Nayak <[email protected]> * added testcase for vtgate vars Signed-off-by: Arindam Nayak <[email protected]> * implement pr suggestion Signed-off-by: Arindam Nayak <[email protected]> * trying to work with throttler Signed-off-by: Ajeet jain <[email protected]> * use ks1 mysql ports for other tablets in ks2 Signed-off-by: Arindam Nayak <[email protected]> * converted on int keys Signed-off-by: Ajeet jain <[email protected]> * Rebase test_master with latest Cluster code (#22) * pick latest fix from cluster_for_test Signed-off-by: Arindam Nayak <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * Tabletmanager2 test cases in GO using cluster (#23) * tabletmanager lock unlock table test case Signed-off-by: Ajeet jain <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * Vtctld Test cases in Go using cluster (#25) * converted vtctld_test.py to go Signed-off-by: Arindam Nayak <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * Converted schema.py testcase (#26) * migrated one of testcase from schema.py to schema_test.go Signed-off-by: Arindam Nayak <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * Tablet Manager test cases in Go using cluster (#27) * converted tabletmanager test cases to go Signed-off-by: Ajeet jain <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * Converted keyspace test to go (#28) * ported testcase of keyspace_test.py Signed-off-by: Arindam Nayak <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * Converted sharded test from py to go (#29) * Converted sharded test from py to go Signed-off-by: Arindam Nayak <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * Added testcase for mysqlctl process Signed-off-by: saurabh <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * removed unused variables Signed-off-by: saurabh <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * removing comment Signed-off-by: saurabh <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * addressed review comments Signed-off-by: saurabh <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * removed cleandir flag from vttablet teardown Signed-off-by: Arindam Nayak <[email protected]> * vtgate buffer testcase migrated in go Signed-off-by: saurabh <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * TabletManager remaining test cases TabletManager remaining test cases in GO Signed-off-by: Ajeet jain <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * moved sql start to non-blocking mode (#35) * moved sql start to non-blocking mode Signed-off-by: Arindam Nayak <[email protected]> Signed-off-by: Arindam Nayak <[email protected]> * added testcase for vtgate vars Signed-off-by: Arindam Nayak <[email protected]> * redirect process errors to log files (#38) Signed-off-by: Arindam Nayak <[email protected]> * debug the test error in ci Signed-off-by: Arindam Nayak <[email protected]> * fix initial sharding multi Signed-off-by: Arindam Nayak <[email protected]> * fixed protected mysqlctl teardown Signed-off-by: Arindam Nayak <[email protected]> * removed sleep time Signed-off-by: Ajeet jain <[email protected]> * refactor mysqlctl start and stop Signed-off-by: Arindam Nayak <[email protected]> * Fixed multisplitdiff command Signed-off-by: Arindam Nayak <[email protected]> * added log statement for error condition Signed-off-by: Arindam Nayak <[email protected]> * Ignoring Python tests which are moved to GO (#40) Signed-off-by: Ajeet jain <[email protected]> * readme for go endtoend test cases Signed-off-by: Ajeet jain <[email protected]> * Update README.md * Fixed byte column test cases Signed-off-by: Ajeet jain <[email protected]> * lint fixes Signed-off-by: Ajeet jain <[email protected]> * updated comments Signed-off-by: Arindam Nayak <[email protected]> * restructure of launch cluster Signed-off-by: Ajeet jain <[email protected]> * fix tear down code Signed-off-by: Ajeet jain <[email protected]> * Refactor code Signed-off-by: Arindam Nayak <[email protected]> * fix the throttler test cases Signed-off-by: Ajeet jain <[email protected]> * fix the static checks Signed-off-by: Ajeet jain <[email protected]> * disable running python test cases in travis Signed-off-by: Ajeet jain <[email protected]> * fixed static checks Signed-off-by: Ajeet jain <[email protected]> * removed unrequired line to set RBR mode Signed-off-by: Ajeet jain <[email protected]> * Add matrix build for mysql Signed-off-by: Morgan Tocker <[email protected]> * Add additional flavors, move flaky test Signed-off-by: Morgan Tocker <[email protected]> * vindex: add required NeedVCursor function There's currently no way to know if a vindex requires the vcursor. We need this knowledge to prevent vreplication from choosing a vindex that requires a VCursor. This change requires all vindexes to report if they need the vcursor or not. Signed-off-by: Sugu Sougoumarane <[email protected]> * vrepl: choose best vindex instead of primary Signed-off-by: Sugu Sougoumarane <[email protected]> * few of the reparent test cases Signed-off-by: Ajeet jain <[email protected]> * vttablet-up.sh : Adds detection of mysqld launch failure. Given failure, tests for further for presence of apparmor. Exits with error and recommendation to disable. Signed-off-by: ChrisR <[email protected]> * completed all the reparent tests Signed-off-by: Ajeet jain <[email protected]> * Remove MariaDB 10.1 Re-enable unit race Change CI git checkout to be v2.0 Disable test caching Signed-off-by: Morgan Tocker <[email protected]> * Revert some of the MariaDB changes, fix unit_race Signed-off-by: Morgan Tocker <[email protected]> * Add debugging for macOS issue Signed-off-by: Morgan Tocker <[email protected]> * Add additional flaky test Signed-off-by: Morgan Tocker <[email protected]> * Add sleep for macOS Signed-off-by: Morgan Tocker <[email protected]> * Disable macOS local example for now (flaky) Signed-off-by: Morgan Tocker <[email protected]> * Disable unit_race again Signed-off-by: Morgan Tocker <[email protected]> * updated test cases for reparent Signed-off-by: Ajeet jain <[email protected]> * Resharding endtoend testcases in Go migrated from Python (#44) Signed-off-by: Ajeet jain <[email protected]> * fix vtgate schema testcases Signed-off-by: Ajeet jain <[email protected]> * Convert binlog.py to go version (#41) Signed-off-by: Arindam Nayak <[email protected]> * fixed range based reparenting Signed-off-by: Ajeet jain <[email protected]> * removed unrequired comments Signed-off-by: Ajeet jain <[email protected]> * Modified apparmor detection to passive, added additional investigation info. Signed-off-by: ChrisR <[email protected]> * make-release-packages.sh: Disable shellcheck 1091 and Add README pointing to local install instructions Signed-off-by: Gary Edgar <[email protected]> * review comments addressed Signed-off-by: Ajeet jain <[email protected]> * Splitting github endtoend action into 2 files Signed-off-by: Ajeet jain <[email protected]> * vindex: NeedVCursor->NeedsVCursor Signed-off-by: Sugu Sougoumarane <[email protected]> * Set correct tablet type to fix failing test Signed-off-by: Arindam Nayak <[email protected]> * Fixing initial sharding multi Signed-off-by: Arindam Nayak <[email protected]> * fix the assertions Signed-off-by: Arindam Nayak <[email protected]> * fixed master-spare test case Signed-off-by: Ajeet jain <[email protected]> * Testing dockerized test in github workflow Signed-off-by: Arindam Nayak <[email protected]> * Vertical split testcase migrated in go (#46) Vertical split endtoend testcases in Go migrated from Python Signed-off-by: saurabh <[email protected]> * Adjusted shard number for testcase Signed-off-by: Arindam Nayak <[email protected]> * Reverting changes for config.json Signed-off-by: Arindam Nayak <[email protected]> * Refactor vitess/lite Dockerfiles. (vitessio#5592) Signed-off-by: Anthony Yeh <[email protected]> Co-authored-by: Arindam Nayak <[email protected]> Co-authored-by: saurabh408 <[email protected]> Co-authored-by: Morgan Tocker <[email protected]> Co-authored-by: Sugu Sougoumarane <[email protected]> Co-authored-by: ChrisR <[email protected]> Co-authored-by: Gary Edgar <[email protected]> Co-authored-by: Anthony Yeh <[email protected]> Co-authored-by: Deepthi Sigireddi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arindam Nayak [email protected]
If this is approved, I can remove this one from config.json.