Add ICryptoBackend.Sign #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
earlbread
requested review from
dahlia,
longfin,
limebell,
riemannulus and
moreal
dahlia
reviewed
Jul 21, 2020
longfin
previously approved these changes
Jul 21, 2020
Co-authored-by: Hong Minhee (洪 民憙) <[email protected]>
longfin
previously approved these changes
Jul 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #932 +/- ##
===========================================
- Coverage 87.91% 18.87% -69.05%
===========================================
Files 263 263
Lines 24217 24226 +9
===========================================
- Hits 21291 4573 -16718
- Misses 1522 19434 +17912
+ Partials 1404 219 -1185
|
dahlia
suggested changes
Jul 21, 2020
longfin
previously approved these changes
Jul 21, 2020
dahlia
previously approved these changes
Jul 21, 2020
limebell
previously approved these changes
Jul 21, 2020
moreal
reviewed
Jul 21, 2020
limebell
approved these changes
Jul 21, 2020
moreal
approved these changes
Jul 21, 2020
longfin
approved these changes
Jul 21, 2020
dahlia
approved these changes
Jul 21, 2020
riemannulus
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
ICryptoBackend.Sign()method to enable signing library changes. Also, this modifiesPrivateKeyto storePublicKeyinstead of generating it every time.