Prevent Swarm<T>.GetDemandBlockHashes() from being hanged when a peer's chain is during reorg #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 0.9-maintenance #884 +/- ##
===================================================
- Coverage 87.56% 87.29% -0.28%
===================================================
Files 250 247 -3
Lines 22675 22062 -613
===================================================
- Hits 19856 19259 -597
+ Misses 1473 1468 -5
+ Partials 1346 1335 -11
|
earlbread
previously approved these changes
May 29, 2020
longfin
reviewed
May 29, 2020
in order to add a unit test for it. [changelog skip]
longfin
approved these changes
May 29, 2020
moreal
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug #880.
Swarm<T>.GetDemandBlockHashes()methodinternal(wasprivate) and add unit tests on it.Swarm<T>.GetDemandBlockHashes()method from being hanged when a peer's chain is during reorg.