Improve reply throughput of Swarm<T>
#849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move NetMQMessage translation to the outside of replying callback
longfin
force-pushed
the
feature/reply-throughput
branch
from
338206d to
6e77299
Compare
longfin
changed the title
Swarm<T>
Codecov Report
@@ Coverage Diff @@
## master #849 +/- ##
==========================================
+ Coverage 87.47% 87.51% +0.03%
==========================================
Files 249 249
Lines 22620 22619 -1
==========================================
+ Hits 19787 19795 +8
+ Misses 1488 1478 -10
- Partials 1345 1346 +1
|
moreal
approved these changes
Apr 22, 2020
earlbread
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves response throughput of
Swarm<T>by arranging the timing of.ToNetMQMessage(). Moving it to the outside ofDoReply()can help with its concurrency.