Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected error on non-ASCII passphrases #845

Merged
merged 2 commits into from
Apr 9, 2020

Conversation

dahlia
Copy link
Contributor

@dahlia dahlia commented Apr 9, 2020

See also the changelog. Also upgraded Bouncy Castle to the latest version.

@dahlia dahlia added the bug Something isn't working label Apr 9, 2020
@dahlia dahlia requested review from longfin, earlbread and moreal April 9, 2020 09:29
@dahlia dahlia self-assigned this Apr 9, 2020
@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #845 into master will decrease coverage by 0.00%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
- Coverage   87.48%   87.47%   -0.01%     
==========================================
  Files         249      249              
  Lines       22600    22601       +1     
==========================================
  Hits        19771    19771              
+ Misses       1486     1485       -1     
- Partials     1343     1345       +2     
Impacted Files Coverage Δ
...ibplanet.Tests/KeyStore/ProtectedPrivateKeyTest.cs 36.30% <66.66%> (-0.05%) ⬇️
Libplanet.Tests/KeyStore/Kdfs/KdfTest.cs 100.00% <100.00%> (ø)
Libplanet/KeyStore/Kdfs/Pbkdf2.cs 83.80% <100.00%> (ø)
Libplanet/Net/Swarm.cs 84.47% <0.00%> (-0.14%) ⬇️
Libplanet/Net/Protocols/KademliaProtocol.cs 65.01% <0.00%> (+0.38%) ⬆️

@dahlia dahlia merged commit fb38a16 into planetarium:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants