Fixed a bug when broadcasting #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limebell
added
bug
Codecov Report
@@ Coverage Diff @@
## master #788 +/- ##
==========================================
- Coverage 86.42% 80.17% -6.25%
==========================================
Files 227 61 -166
Lines 19524 1513 -18011
==========================================
- Hits 16873 1213 -15660
+ Misses 1439 271 -1168
+ Partials 1212 29 -1183 |
longfin
previously approved these changes
Feb 6, 2020
earlbread
previously approved these changes
Feb 6, 2020
moreal
previously approved these changes
Feb 6, 2020
limebell
force-pushed
the
bugfix/broadcast
branch
from
b49e1a3 to
0a67c11
Compare
earlbread
previously approved these changes
Feb 6, 2020
longfin
previously approved these changes
Feb 7, 2020
moreal
previously approved these changes
Feb 7, 2020
dahlia
reviewed
Feb 7, 2020
limebell
force-pushed
the
bugfix/broadcast
branch
from
6ae1b26 to
adb73bd
Compare
moreal
previously approved these changes
Feb 7, 2020
earlbread
previously approved these changes
Feb 7, 2020
dahlia
previously approved these changes
Feb 7, 2020
limebell
force-pushed
the
bugfix/broadcast
branch
from
77f8bbc to
fb0bcdc
Compare
longfin
previously approved these changes
Feb 11, 2020
earlbread
previously approved these changes
Feb 11, 2020
moreal
previously approved these changes
Feb 11, 2020
limebell
force-pushed
the
bugfix/broadcast
branch
from
fb0bcdc to
c5b5e34
Compare
earlbread
approved these changes
Feb 11, 2020
longfin
approved these changes
Feb 11, 2020
moreal
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where
Swarm<T>broadcast a message to its source peer when guaranteeing minimum peers to broadcast.