Make BlockHeader and BlockDigest public #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #785 +/- ##
==========================================
- Coverage 86.77% 86.76% -0.02%
==========================================
Files 232 232
Lines 20468 20472 +4
==========================================
+ Hits 17761 17762 +1
- Misses 1482 1486 +4
+ Partials 1225 1224 -1
|
longfin
previously approved these changes
Feb 6, 2020
limebell
requested changes
Feb 6, 2020
limebell
previously approved these changes
Feb 6, 2020
Co-Authored-By: Chanhyuck <[email protected]>
earlbread
force-pushed
the
make-public
branch
from
e47c133 to
1212265
Compare
Merged
limebell
previously approved these changes
Feb 7, 2020
longfin
previously approved these changes
Feb 7, 2020
dahlia
suggested changes
Feb 7, 2020
Co-Authored-By: Hong Minhee <[email protected]>
dahlia
approved these changes
Feb 7, 2020
moreal
approved these changes
Feb 7, 2020
longfin
approved these changes
Feb 7, 2020
limebell
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
BlockHeaderandBlockDigestclass public to implementRocksDBStore.