Enrich routing table #772
Merged
Enrich routing table #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
reviewed
Jan 23, 2020
limebell
force-pushed
the
feature/peer-info
branch
from
5cb0bda to
89a6e04
Compare
longfin
previously approved these changes
Jan 23, 2020
limebell
force-pushed
the
feature/peer-info
branch
from
89a6e04 to
03f7f8e
Compare
limebell
force-pushed
the
feature/peer-info
branch
from
f191398 to
d4522c5
Compare
earlbread
approved these changes
Jan 29, 2020
dahlia
reviewed
Jan 29, 2020
earlbread
previously approved these changes
Jan 29, 2020
@dahlia It will be great to be in another PR, since some features are KademliaProtocol specific so need a discussion to be added in IProtocol or not. |
limebell
force-pushed
the
feature/peer-info
branch
from
7b918ba to
7841b7c
Compare
earlbread
previously approved these changes
Jan 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #772 +/- ##
==========================================
- Coverage 86.62% 86.45% -0.17%
==========================================
Files 225 226 +1
Lines 19380 19427 +47
==========================================
+ Hits 16787 16795 +8
- Misses 1393 1425 +32
- Partials 1200 1207 +7
|
dahlia
suggested changes
Jan 30, 2020
limebell
force-pushed
the
feature/peer-info
branch
from
7841b7c to
5042def
Compare
dahlia
suggested changes
Jan 30, 2020
limebell
force-pushed
the
feature/peer-info
branch
2 times, most recently
from
2ae8f34 to
7efec13
Compare
dahlia
previously approved these changes
Jan 30, 2020
earlbread
previously approved these changes
Jan 30, 2020
moreal
reviewed
Jan 30, 2020
longfin
previously approved these changes
Jan 30, 2020
moreal
previously approved these changes
Jan 30, 2020
limebell
force-pushed
the
feature/peer-info
branch
from
7efec13 to
2477b3d
Compare
dahlia
approved these changes
Jan 30, 2020
earlbread
approved these changes
Jan 30, 2020
moreal
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Routing table now stores peers with its last updated time, last checked (ping/pong) time and its latency.