Implement block header #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #757 +/- ##
==========================================
- Coverage 86.4% 86.36% -0.05%
==========================================
Files 222 223 +1
Lines 19218 19179 -39
==========================================
- Hits 16605 16563 -42
+ Misses 1419 1410 -9
- Partials 1194 1206 +12
|
limebell
force-pushed
the
feature/block-header
branch
from
7ceff9d to
7718c04
Compare
longfin
reviewed
Jan 14, 2020
limebell
force-pushed
the
feature/block-header
branch
from
7718c04 to
aa41eb6
Compare
longfin
previously approved these changes
Jan 14, 2020
earlbread
previously approved these changes
Jan 14, 2020
earlbread
previously approved these changes
Jan 14, 2020
limebell
force-pushed
the
feature/block-header
branch
from
79f75af to
1c3cd6e
Compare
|
I made |
earlbread
previously approved these changes
Jan 14, 2020
…tation to string instead of byte array
limebell
force-pushed
the
feature/block-header
branch
from
1c3cd6e to
d4a206c
Compare
earlbread
previously approved these changes
Jan 14, 2020
earlbread
approved these changes
Jan 15, 2020
longfin
approved these changes
Jan 15, 2020
moreal
approved these changes
Jan 15, 2020
dahlia
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
RawBlockcan be in two different states which are:To be clear, separated
BlockDigestwhich contains only transaction ids fromRawBlock. Additionally added a structure namedBlockHeaderwhich summarizes block information except transactions.To sum it up, there are now 4 block related objects:
Block: A class represents block. This contains all block parameters and transactions.RawBlock: A serialization used in network transportation. This contains serialized transactionsBlockHeader.BlockDigest: A serialization used in storage. This contains transaction ids andBlockHeader.BlockHeader: A serialization describes block information. This does not neither transactions nor transaction ids.Caution: This patch is based on #751
This closes #749.