-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable NetMQRuntime count #727
Merged
limebell
merged 2 commits into
planetarium:master
from
wwhurin:configurable-netmqruntime-count
Dec 14, 2019
Merged
Configurable NetMQRuntime count #727
limebell
merged 2 commits into
planetarium:master
from
wwhurin:configurable-netmqruntime-count
Dec 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/rebase |
09ef81b
to
d2b1763
Compare
earlbread
previously approved these changes
Dec 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #727 +/- ##
==========================================
+ Coverage 86.65% 86.67% +0.01%
==========================================
Files 221 221
Lines 18737 18741 +4
==========================================
+ Hits 16236 16243 +7
+ Misses 1344 1341 -3
Partials 1157 1157
|
longfin
previously approved these changes
Dec 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
d2b1763
to
a275393
Compare
limebell
requested changes
Dec 14, 2019
a275393
to
e08a220
Compare
limebell
approved these changes
Dec 14, 2019
longfin
approved these changes
Dec 14, 2019
earlbread
approved these changes
Dec 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title says it all.