Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Swarm<T>'s Event internal [skip changelog] #725

Merged
merged 2 commits into from
Dec 14, 2019

Conversation

Oaroomy
Copy link
Contributor

@Oaroomy Oaroomy commented Dec 14, 2019

Changed TxReceived, BlockReceived

@codecov
Copy link

codecov bot commented Dec 14, 2019

Codecov Report

Merging #725 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #725      +/-   ##
==========================================
- Coverage   86.67%   86.65%   -0.03%     
==========================================
  Files         221      221              
  Lines       18737    18737              
==========================================
- Hits        16241    16236       -5     
- Misses       1339     1344       +5     
  Partials     1157     1157
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 82.92% <100%> (ø) ⬆️
Libplanet/Net/Protocols/KBucket.cs 90.99% <0%> (-2.71%) ⬇️
Libplanet.Tests/Net/Protocols/TestSwarm.cs 77.85% <0%> (-0.74%) ⬇️

Copy link
Member

@longfin longfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@limebell limebell merged commit 8c96330 into planetarium:master Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants