Improve ListAllStateReferences performance #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #701 +/- ##
==========================================
- Coverage 86.23% 86.14% -0.09%
==========================================
Files 221 221
Lines 18134 18131 -3
==========================================
- Hits 15637 15619 -18
- Misses 1423 1438 +15
Partials 1074 1074
|
moreal
previously approved these changes
Dec 2, 2019
limebell
reviewed
Dec 2, 2019
longfin
reviewed
Dec 2, 2019
earlbread
force-pushed
the
list-all-state-ref
branch
from
1cb5456 to
4da4705
Compare
dahlia
reviewed
Dec 2, 2019
earlbread
force-pushed
the
list-all-state-ref
branch
2 times, most recently
from
c6d6726 to
ab78000
Compare
longfin
previously approved these changes
Dec 3, 2019
moreal
previously approved these changes
Dec 3, 2019
earlbread
force-pushed
the
list-all-state-ref
branch
from
ab78000 to
c219844
Compare
earlbread
force-pushed
the
list-all-state-ref
branch
from
c219844 to
3f6216d
Compare
longfin
approved these changes
Dec 3, 2019
dahlia
approved these changes
Dec 3, 2019
limebell
approved these changes
Dec 3, 2019
moreal
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves
StoreExtension.ListAllStateReferencestoIStore.ListAllStateReferencesand improve the preformance of the method.