Add PreloadBlockDownloadFailed event handler #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
suggested changes
Nov 26, 2019
earlbread
force-pushed
the
preload-failed-event
branch
from
4be86af to
7dd35f9
Compare
Codecov Report
@@ Coverage Diff @@
## master #694 +/- ##
=========================================
+ Coverage 86.11% 86.21% +0.1%
=========================================
Files 220 221 +1
Lines 18096 18134 +38
=========================================
+ Hits 15583 15634 +51
+ Misses 1441 1426 -15
- Partials 1072 1074 +2
|
dahlia
reviewed
Nov 26, 2019
earlbread
force-pushed
the
preload-failed-event
branch
from
7dd35f9 to
1b9415c
Compare
dahlia
reviewed
Nov 26, 2019
dahlia
previously approved these changes
Nov 26, 2019
dahlia
previously approved these changes
Nov 26, 2019
limebell
previously approved these changes
Nov 27, 2019
moreal
previously approved these changes
Nov 27, 2019
earlbread
force-pushed
the
preload-failed-event
branch
from
304bd20 to
55d3ac6
Compare
dahlia
suggested changes
Nov 28, 2019
dahlia
reviewed
Nov 28, 2019
earlbread
force-pushed
the
preload-failed-event
branch
from
1a7555f to
e989ee4
Compare
dahlia
previously approved these changes
Nov 28, 2019
longfin
previously approved these changes
Nov 28, 2019
earlbread
force-pushed
the
preload-failed-event
branch
from
e989ee4 to
e614ba1
Compare
longfin
previously approved these changes
Nov 28, 2019
moreal
suggested changes
Nov 28, 2019
earlbread
force-pushed
the
preload-failed-event
branch
from
2ca1830 to
9b24187
Compare
dahlia
previously approved these changes
Nov 29, 2019
longfin
previously approved these changes
Nov 29, 2019
Co-Authored-By: Hong Minhee <[email protected]>
Co-Authored-By: Lee Dogeon <[email protected]>
earlbread
force-pushed
the
preload-failed-event
branch
from
9b24187 to
d6fe8ac
Compare
longfin
approved these changes
Dec 2, 2019
moreal
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the block downloading fails in
Swarm<T>.PreloadAsync,Swarm<T>became to callSwarm<T>.PreloadBlockDownloadFailedevent handler. If the event handler doesn't exist,Swarm<T>throwsSwarmException.