Store blocks and transactions as bare files instead of embeded files in LiteDB #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #662 +/- ##
=========================================
- Coverage 87.62% 87.3% -0.33%
=========================================
Files 218 218
Lines 17714 17760 +46
=========================================
- Hits 15522 15505 -17
- Misses 1134 1195 +61
- Partials 1058 1060 +2
|
longfin
reviewed
Nov 11, 2019
earlbread
reviewed
Nov 11, 2019
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Nov 13, 2019
dahlia
added a commit
to dahlia/libplanet
that referenced
this pull request
Nov 13, 2019
longfin
previously approved these changes
Nov 13, 2019
limebell
previously approved these changes
Nov 13, 2019
earlbread
approved these changes
Nov 13, 2019
longfin
approved these changes
Nov 13, 2019
moreal
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes blocks and transactions stored as bare files, instead of LiteDB's
FileStorage. Therefore, now it cannot be called justLiteDBStoreanymore, so I renamed it toDefaultStore. As more than a single file are made, it became to take a directory instead of a single file.Note that this still has only a single LiteDB file yet. I'm going to make another patch to make each chain ID has its own LiteDB file.
Here are small and not-that-accurate benchmarks:
LiteDBStore(Linux)DefaultStore(Linux)LiteDBStore(macOS)DefaultStore(macOS)LiteDBStore(Windows)DefaultStore(Windows)