Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IReadOnlyList implementation from BlockChain<T> #630

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Remove IReadOnlyList implementation from BlockChain<T> #630

merged 1 commit into from
Nov 7, 2019

Conversation

earlbread
Copy link
Contributor

@earlbread earlbread commented Oct 29, 2019 •
edited
Loading

This removes the IReadOnlyList<T> implementation of BlockChain <T>.
Closes #606.

@codecov
Copy link

codecov bot commented Oct 29, 2019 •
edited
Loading

Codecov Report

Merging #630 into master will decrease coverage by 0.09%.
The diff coverage is 99.5%.

@@            Coverage Diff            @@
##           master     #630     +/-   ##
=========================================
- Coverage   88.27%   88.18%   -0.1%     
=========================================
  Files         217      216      -1     
  Lines       17248    17133    -115     
=========================================
- Hits        15226    15109    -117     
- Misses       1145     1148      +3     
+ Partials      877      876      -1
Impacted Files Coverage Δ
Libplanet.Tests/Blockchain/NullPolicy.cs 100% <100%> (ø) ⬆️
...lanet.Tests/Blockchain/Policies/BlockPolicyTest.cs 97.76% <100%> (-0.95%) ⬇️
Libplanet/Net/Swarm.cs 85.66% <100%> (-0.49%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 98.81% <100%> (+0.01%) ⬆️
Libplanet/Blockchain/Policies/BlockPolicy.cs 86.45% <100%> (ø) ⬆️
Libplanet/Blockchain/BlockChain.cs 95.49% <100%> (+0.96%) ⬆️
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.76% <98.75%> (+0.01%) ⬆️
Libplanet/Net/NetMQSocketExtension.cs 77.55% <0%> (-4.09%) ⬇️
Libplanet/Crypto/PrivateKey.cs 86.2% <0%> (+0.86%) ⬆️

@earlbread earlbread force-pushed the remove-ireadonly-list branch 4 times, most recently from 7318922 to 82a8802 Compare October 29, 2019 10:41
@earlbread earlbread marked this pull request as ready for review October 29, 2019 10:41
@earlbread earlbread self-assigned this Oct 29, 2019
@earlbread earlbread force-pushed the remove-ireadonly-list branch 3 times, most recently from 4aaef88 to 89a38af Compare October 31, 2019 07:18
longfin
longfin reviewed Nov 1, 2019
View reviewed changes
@earlbread earlbread force-pushed the remove-ireadonly-list branch from 89a38af to c54098c Compare November 4, 2019 10:53
limebell
limebell previously approved these changes Nov 4, 2019
View reviewed changes
longfin
longfin previously approved these changes Nov 4, 2019
View reviewed changes
moreal
moreal previously approved these changes Nov 4, 2019
View reviewed changes
dahlia
dahlia reviewed Nov 6, 2019
View reviewed changes
@earlbread earlbread dismissed stale reviews from moreal, longfin, and limebell via 0b59bce November 6, 2019 06:28
@earlbread earlbread force-pushed the remove-ireadonly-list branch from c54098c to 0b59bce Compare November 6, 2019 06:28
@earlbread earlbread force-pushed the remove-ireadonly-list branch from 0b59bce to e065434 Compare November 6, 2019 06:54
@earlbread earlbread requested a review from moreal November 6, 2019 07:05
longfin
longfin previously approved these changes Nov 6, 2019
View reviewed changes
moreal
moreal previously approved these changes Nov 6, 2019
View reviewed changes
@earlbread earlbread dismissed stale reviews from moreal and longfin via 8d3a1f2 November 6, 2019 09:59
@earlbread earlbread force-pushed the remove-ireadonly-list branch from e065434 to 8d3a1f2 Compare November 6, 2019 09:59
@longfin
Copy link
Member

longfin commented Nov 7, 2019

Tests seem to fail. 😢

[xUnit.net 00:01:31.14]     Libplanet.Tests.Net.SwarmTest.PreloadRetryWithNextPeers(blockCount: 4) [FAIL]
Failed   Libplanet.Tests.Net.SwarmTest.PreloadRetryWithNextPeers(blockCount: 4)
Error Message:
 Assert.Equal() Failure
Expected: BlockChain`1 { BlockHashes = [02e9c9f7b1a530844dcc1b616c189c0a238a80b834bdd23f9faaaed8014c0e9d, a0dabb5d47d12457b9fa84b3790d66086051f037a831afe93d371d24f2f33f00, 3ee80c40060ab40c74564a05cdd18e2020c94991c4ebf894fdc59e86b3d00200, 054ad6036719743264f11a06d9729c92626f57a51fadafc0fb64ec0b188c2800], Count = 4, Id = f931b434-dedc-48ba-8a83-15d31dadf24f, Item = (throws TargetParameterCountException), Item = (throws TargetParameterCountException), ... }
Actual:   BlockChain`1 { BlockHashes = [02e9c9f7b1a530844dcc1b616c189c0a238a80b834bdd23f9faaaed8014c0e9d, a0dabb5d47d12457b9fa84b3790d66086051f037a831afe93d371d24f2f33f00, 3ee80c40060ab40c74564a05cdd18e2020c94991c4ebf894fdc59e86b3d00200, 054ad6036719743264f11a06d9729c92626f57a51fadafc0fb64ec0b188c2800], Count = 4, Id = 858d58b6-cd96-4037-9bde-96f98764d873, Item = (throws TargetParameterCountException), Item = (throws TargetParameterCountException), ... }

@earlbread earlbread force-pushed the remove-ireadonly-list branch from 8d3a1f2 to 0b64f5c Compare November 7, 2019 02:49
@earlbread
Copy link
Contributor Author

😢 Fixed!

@earlbread earlbread force-pushed the remove-ireadonly-list branch from 0b64f5c to 6779fd9 Compare November 7, 2019 04:34
@earlbread earlbread requested review from longfin and moreal November 7, 2019 05:47
@earlbread earlbread merged commit 7310035 into planetarium:master Nov 7, 2019
@earlbread earlbread deleted the remove-ireadonly-list branch November 7, 2019 05:54
@dahlia dahlia mentioned this pull request Dec 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dahlia dahlia dahlia approved these changes

@longfin longfin longfin approved these changes

@limebell limebell Awaiting requested review from limebell

@moreal moreal Awaiting requested review from moreal

Assignees

@earlbread earlbread

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove IReadOnlyList implementation from BlockChain<T>
5 participants
@earlbread @longfin @dahlia @limebell @moreal