Separate cache checking with removing #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
=========================================
+ Coverage 90.88% 90.9% +0.01%
=========================================
Files 202 202
Lines 15761 15775 +14
=========================================
+ Hits 14325 14340 +15
+ Misses 1131 1129 -2
- Partials 305 306 +1
|
longfin
previously approved these changes
Oct 23, 2019
earlbread
reviewed
Oct 24, 2019
longfin
previously approved these changes
Oct 24, 2019
earlbread
previously approved these changes
Oct 24, 2019
moreal
previously approved these changes
Oct 24, 2019
limebell
force-pushed
the
remove-seperate
branch
from
45ce76d to
46536e2
Compare
limebell
force-pushed
the
remove-seperate
branch
from
46536e2 to
65a9c3d
Compare
longfin
approved these changes
Oct 25, 2019
earlbread
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch separates
KademliaProtocol<T>.CheckReplacementCacheAsync()fromKademliaProtocol<T>.RemovePeerAsync().