Fix behavior of KademliaProtocol<T>.RefreshTableAsync #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limebell
force-pushed
the
fix-refreshtable
branch
from
0221610 to
c300899
Compare
moreal
previously approved these changes
Oct 17, 2019
longfin
reviewed
Oct 17, 2019
limebell
force-pushed
the
fix-refreshtable
branch
from
c300899 to
5b8a93b
Compare
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
==========================================
- Coverage 90.9% 90.88% -0.02%
==========================================
Files 202 202
Lines 15699 15723 +24
==========================================
+ Hits 14271 14290 +19
- Misses 1130 1134 +4
- Partials 298 299 +1
|
longfin
previously approved these changes
Oct 17, 2019
earlbread
previously approved these changes
Oct 17, 2019
limebell
force-pushed
the
fix-refreshtable
branch
from
5b8a93b to
7da2ded
Compare
dahlia
reviewed
Oct 18, 2019
limebell
force-pushed
the
fix-refreshtable
branch
from
33db658 to
aee325c
Compare
earlbread
previously approved these changes
Oct 21, 2019
limebell
force-pushed
the
fix-refreshtable
branch
from
aee325c to
ca1f010
Compare
limebell
force-pushed
the
fix-refreshtable
branch
from
ca1f010 to
b4d0889
Compare
longfin
approved these changes
Oct 22, 2019
earlbread
approved these changes
Oct 22, 2019
moreal
approved these changes
Oct 22, 2019
dahlia
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug that
KademliaProcol<T>.RefreshTableAsync()did not remove staled peers. And became to check only least recently used peers in each table to prevent too frequent live checking.This closes #568.