Refactor Swarm<T> constructor
#581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longfin
force-pushed
the
feature/refactor-swarm-ctor
branch
from
b972018 to
7ea42f5
Compare
Codecov Report
@@ Coverage Diff @@
## master #581 +/- ##
==========================================
+ Coverage 90.72% 90.84% +0.11%
==========================================
Files 202 202
Lines 15542 15530 -12
==========================================
+ Hits 14101 14108 +7
+ Misses 1149 1130 -19
Partials 292 292
|
longfin
force-pushed
the
feature/refactor-swarm-ctor
branch
4 times, most recently
from
67e9f6e to
9d5810e
Compare
longfin
force-pushed
the
feature/refactor-swarm-ctor
branch
from
9d5810e to
57b94b5
Compare
longfin
changed the title
Swarm<T> constructorSwarm<T> constructor
earlbread
previously approved these changes
Oct 16, 2019
limebell
previously approved these changes
Oct 16, 2019
dahlia
reviewed
Oct 16, 2019
moreal
previously approved these changes
Oct 16, 2019
Co-Authored-By: Hong Minhee <[email protected]>
dahlia
approved these changes
Oct 16, 2019
earlbread
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactor
Swarm<T>'s constructor as belowlingerparameter is replaced withwaitForinSwarm<T>.StopAsync().dialTimeoutparameter is moved toSwarm<T>.PreloadAsync()andSwarm<T>.StartAsync().And, it also makes some changes as below
Swarm<T>._blockChainusing the auto-implemented property.Swarm<T>._protocolusing the auto-implemented property.