-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target netstandard2.0 as well as netcoreapp2.2 #561
Merged
longfin
merged 4 commits into
planetarium:master
from
RozzaysRed:targetMultipleFrameworks
Oct 11, 2019
Merged
Target netstandard2.0 as well as netcoreapp2.2 #561
longfin
merged 4 commits into
planetarium:master
from
RozzaysRed:targetMultipleFrameworks
Oct 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/rebase |
9f6430e
to
63159c6
Compare
I think it needs to mention this change in the changelog. |
63159c6
to
f1778a0
Compare
moreal
reviewed
Oct 10, 2019
Co-Authored-By: Lee Dogeon <[email protected]>
Co-Authored-By: Lee Dogeon <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
==========================================
+ Coverage 90.79% 90.82% +0.03%
==========================================
Files 201 201
Lines 15219 15219
==========================================
+ Hits 13818 13823 +5
+ Misses 1111 1106 -5
Partials 290 290
|
longfin
approved these changes
Oct 11, 2019
earlbread
approved these changes
Oct 11, 2019
@RozzaysRed Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #209