Fix an issue where currency does not work correctly in dotnet6 #3880
Conversation
s2quake
force-pushed
the
fix/currency-dotnet6
branch
from
2aa539e to
ea9808e
Compare
s2quake
changed the title
| private static IValue SerializeForHash( | ||
| IImmutableSet<Address>? minters, | ||
| string ticker, | ||
| byte decimalPlaces, | ||
| (BigInteger Major, BigInteger Minor)? maximumSupply, | ||
| bool totalSupplyTrackable) |
There was a problem hiding this comment.
I think it's not, That code has been moved into GetHash.
amended 997922b
There was a problem hiding this comment.
Wasn't there a reason why GetHash() and SerializeForHash() were separate in the first place? 🤔
There was a problem hiding this comment.
Ah, nevermind, it was about SerializeForHash() and Serialize(). 🙄
There was a problem hiding this comment.
It might be good to have a simple comment on whether we have a separate serialization scheme. 😐
There was a problem hiding this comment.
It might be good to have a simple comment on whether we have a separate serialization scheme. 😐
3808b22#diff-7975b57b58acd250c0c5fb4f0001c98e298746481661b38ccb8e64c429dda7b5R731
How about this?
There was a problem hiding this comment.
The comment doesn't clarify as to why the Dictionary construction is different from Serialize(), which I think would be the main point of confusion for those seeing the code without context. I'd say the history regarding GetHash() is barely relevant and doesn't need mentioning.
There was a problem hiding this comment.
The comment doesn't clarify as to why the
Dictionaryconstruction is different fromSerialize(), which I think would be the main point of confusion for those seeing the code without context. I'd say the history regardingGetHash()is barely relevant and doesn't need mentioning.
9a8fd89#diff-7975b57b58acd250c0c5fb4f0001c98e298746481661b38ccb8e64c429dda7b5R731
amended
s2quake
force-pushed
the
fix/currency-dotnet6
branch
2 times, most recently
from
6b9b285 to
5298df7
Compare
s2quake
force-pushed
the
fix/currency-dotnet6
branch
from
5298df7 to
b9064f8
Compare
s2quake
force-pushed
the
fix/currency-dotnet6
branch
from
b9064f8 to
a9f0615
Compare
In dotnet6, the following error occurs when building.
CS0188, CS8885: The this object cannot be used before all of its fields are assigned toI tried to change the
Hashfield ofCurrencyto a property, but it was not the correct way to modify it.According to the error message, I just need to avoid calling this method, so I changed the method to static and used it.
The code is less readable, but I was able to solve the problem for now.