pkp/pkp-lib#4787 Reviewer suggestions #426
Conversation
touhidurabir
force-pushed
the
i4787_main
branch
from
99aa445 to
777d2c3
Compare
touhidurabir
force-pushed
the
i4787_main
branch
3 times, most recently
from
5b17018 to
1de524e
Compare
| {{ affiliation }} | ||
| </div> | ||
| <!-- TODO: check alternative of v-html as v-strip-unsafe-html not working --> | ||
| <div v-html="suggestionReason"></div> |
There was a problem hiding this comment.
Need better and secure replacement of v-html .
There was a problem hiding this comment.
This is related to pkp/pkp-lib#9421 , where we have introduced a new directive v-strip-unsafe-html for 3.3/3.4 but has not yet pushed it for 3.5 . So this is just a placeholder to update it once this change or something similar get pushed for 3.5 .
| <!-- TODO: check alternative of v-html as v-strip-unsafe-html not working --> | ||
| <div | ||
| class="text-sm-normal text-secondary" | ||
| v-html="reviewerSuggestion.suggestionReason" |
There was a problem hiding this comment.
Need better and secure replacement of v-html .
There was a problem hiding this comment.
same as #426 (comment)
touhidurabir
force-pushed
the
i4787_main
branch
from
b611774 to
32e368d
Compare
touhidurabir
force-pushed
the
i4787_main
branch
2 times, most recently
from
8440d58 to
a27ed04
Compare
touhidurabir
force-pushed
the
i4787_main
branch
2 times, most recently
from
ab9e907 to
6453f57
Compare
There was a problem hiding this comment.
Thanks @touhidurabir! Not much here.
Questions:
In the "REVIEWER SUGGESTIONS" there is a drop down control that has a "More Actions" indicator. Should that be a three-dot button doing the same thing?
Also I am wondering whether the newly upgraded TinyMCE affects in any way the forms that are being used in this feature, or rather whether we need to consider changes in this issues PRs regarding the upgraded TinyMCE component.
| (actionName) => | ||
| reviewerSuggestionManagerStore[actionName]({ | ||
| reviewerSuggestion: reviewerSuggestion, | ||
| stageAssignmen, |
There was a problem hiding this comment.
Should this be stageAssignment?
| fetchreviewerSuggestion(); | ||
| }); | ||
|
|
||
| fetchreviewerSuggestion(); |
There was a problem hiding this comment.
Should this be fetchreviewerSuggestion()?
| <!-- TODO: check alternative of v-html as v-strip-unsafe-html not working --> | ||
| <div | ||
| class="text-sm-normal text-secondary" | ||
| v-html="reviewerSuggestion.suggestionReason" |
| {{ affiliation }} | ||
| </div> | ||
| <!-- TODO: check alternative of v-html as v-strip-unsafe-html not working --> | ||
| <div v-html="suggestionReason"></div> |
| {{ affiliation }} | ||
| </div> | ||
| <!-- TODO: check alternative of v-html as v-strip-unsafe-html not working --> | ||
| <div v-html="suggestionReason"></div> |
There was a problem hiding this comment.
Should we consider wrapping long strings like the one bellow?
There was a problem hiding this comment.
Yes, we should but I think it should be the part of different task to have a general component to handle such cases instead only for this issue .
touhidurabir
force-pushed
the
i4787_main
branch
from
6453f57 to
ac3352b
Compare
This has broken due to some new changes in the ui lib , otherwise this is how it should be and was previously |
|
@blesildaramirez, it looks like some TinyMCE changes might be needed here -- can you spot anything quickly that needs adaptation for the new version? |
This does not seems like anything related to TinyMce but some changes to the DropdownActions component and the fix is very simple . |
Thanks, @touhidurabir -- do you mean a simple fix that you can tackle, or that you'll need someone to take care of in |
I have already fixed it . Working on the PR update based on code review . |
… no suggestion available
touhidurabir
force-pushed
the
i4787_main
branch
from
6c7cbcc to
f4a4bb4
Compare
for pkp/pkp-lib#4787