Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop "PublishedArticle" from the getObjectType() #63

Closed
jonasraoni opened this issue Feb 21, 2023 · 1 comment
Closed

Drop "PublishedArticle" from the getObjectType() #63

jonasraoni opened this issue Feb 21, 2023 · 1 comment
Assignees
@jonasraoni
Labels
enhancement New feature or request Enhancement:1:Minor
Milestone
3.0.0-0

Comments

@jonasraoni
Copy link
Collaborator

jonasraoni commented Feb 21, 2023 •
edited
Loading

According to comments in the code, it's a "Legacy (OJS pre-3.2)", therefore a migration can be written to get rid of this value in the database and its related handling in the code.

As part of this task, foreign keys might be added. The cascate rule for the delete should be probably set null, to avoid blocking removals, while also allowing the plugin to do its cleanup.
@jonasraoni jonasraoni added this to the 3.0.0 milestone Feb 21, 2023
@jonasraoni jonasraoni self-assigned this Feb 21, 2023
@jonasraoni jonasraoni mentioned this issue Jul 28, 2023
Open
@jonasraoni
Copy link
Collaborator Author

Closed in favor of #63.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Plugins and Themes Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonasraoni jonasraoni

Labels
enhancement New feature or request Enhancement:1:Minor
Projects
Plugins and Themes
Status: Done
Milestone
3.0.0-0
Development

No branches or pull requests
1 participant
@jonasraoni