Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review/refactoring meta issue #21

Open
12 of 17 tasks
jonasraoni opened this issue May 11, 2022 · 0 comments
Open
12 of 17 tasks

Review/refactoring meta issue #21

jonasraoni opened this issue May 11, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@jonasraoni
Copy link
Collaborator

jonasraoni commented May 11, 2022

  • Review user issues in the forum
  • Review the "Refresh" button: perhaps it can happen automatically
  • Replace serialize/unserialize by JSON
  • Remove deprecated code (Config::getVar('i18n', 'client_charset'), AppLocale, etc)
  • Attempt to use the newer jobs module and get rid of Acron/TaskScheduler checks
  • Add auto-formatting for the code
  • include_once('Archive/Tar.php') not needed (Remove the PEAR/Archive_Tar requirement #25)
  • Use namespaces
  • Use PHP 8 features
  • Replace the binary flags by fields: it's complex to view/deal with, better to get it replaced by something simpler (e.g. state machine)
  • Remove non-visited code branches
  • Attempt to use events to detect modifications on the issues/submissions (useful only if the code which looks for modifications is heavy)
  • Review states by checking the ones available in pkppln and locks-o-matic: (Missing mapping for the processing state: harvest-error #20 + Missing mapping for the "inProgress" state #18)
  • Remove non-used locale keys
  • Update README with better instructions (how-to images, troubleshooting, etc) and link/reuse the content inside the plugin
  • Rename PLN to PN (renaming the folder might be problematic)
  • The forum is often orientating users to reset deposits. Sometimes it doesn't make sense, thus this feature should be better controlled.
@jonasraoni jonasraoni self-assigned this May 12, 2022
@jonasraoni jonasraoni added the enhancement New feature or request label May 12, 2022
@jonasraoni jonasraoni moved this to Backlog in Plugins and Themes May 12, 2022
@jonasraoni jonasraoni added this to the 3.0.0 milestone May 12, 2022
@jonasraoni jonasraoni changed the title Review /main code Review/refactoring meta issue Jun 18, 2022
@jonasraoni jonasraoni moved this from Backlog to Under Development in Metadata and Distribution Jun 18, 2022
@jonasraoni jonasraoni moved this from Backlog to Under Development in Plugins and Themes Jun 18, 2022
@jonasraoni jonasraoni removed this from the 3.0.0-0 milestone Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Under Development
Status: Under Development
Development

No branches or pull requests

1 participant