Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing mapping for the "inProgress" state #18

Closed
jonasraoni opened this issue Apr 21, 2022 · 6 comments
Closed

Missing mapping for the "inProgress" state #18

jonasraoni opened this issue Apr 21, 2022 · 6 comments
Assignees
Milestone

Comments

@jonasraoni
Copy link
Collaborator

jonasraoni commented Apr 21, 2022

Describe the bug
A valid answer from the server ends up as an error (Unknown LOCKSS state inProgress) due to a missing mapping.

Screenshots can be seen at the origin:
https://forum.pkp.sfu.ca/t/pkp-pn-plugin-error-unknown-lockss-state-inprogress-eventhough-journal-issues-appear-on-the-list-of-journal-list-spreadsheet/72150/7

PRs

What application are you using?
OJS 3.3.0-10

@jonasraoni
Copy link
Collaborator Author

@asmecher Just a small PR to address this issue, I've been seeing it often in the forum, then I'll port it back for the older branches.

@asmecher
Copy link
Member

Merged #15 for main, thanks! Please back-port to stable-3_3_0, but no further back than that.

FYI, I've just enabled Issues over on the PKP|PN plugin repository (https://github.com/pkp/pln/issues). Feel free to start tracking issues there.

@jonasraoni
Copy link
Collaborator Author

Ok, so here goes the one for stable-3_3_0

@asmecher
Copy link
Member

@jonasraoni, FYI, I've transferred this issue from pkp/pkp-lib, and created 2.0.4-3 and 3.0.0.0 milestones in this repo. I've assigned this issue to 2.0.4-3, which is the first release it'll be included in.

Repository owner moved this from Backlog to Done in Plugins and Themes May 11, 2022
Repository owner moved this from Backlog to Done in Metadata and Distribution May 11, 2022
@jonasraoni
Copy link
Collaborator Author

jonasraoni commented May 11, 2022

@asmecher Please, give me some permissions, I can't set the milestones, assign myself to issues, etc.

Just to confirm, we'll be accumulating several issues into a release, right? Then, when are you planning to release them? Together with the OJS?

This issue needs to be moved to this repository as well: #22

@jonasraoni jonasraoni changed the title [Plugin][PLN] Missing mapping for the "inProgress" state Missing mapping for the "inProgress" state May 11, 2022
@asmecher
Copy link
Member

@jonasraoni, I've added you as a maintainer to the pln repository. Yes, we'll accumulate several fixes into each release. No need to release plugins along with e.g. the OJS release schedule. Normally a new release would either be triggered by a major issue in the plugin, or by the accumulation of enough smaller issues to make it worthwhile; it's discretionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants