Imports: Allow for a Native XML file to be imported if the primary contact ID is not provided #9862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@defstat, could you please take a look at this one? |
defstat
requested changes
Nov 6, 2024
There was a problem hiding this comment.
@kennydude thanks so much for your contribution. Just one minor syntax change and it is ready to be merged!
| @@ -88,7 +88,10 @@ public function handleElement($node) | |||
| $publicationId = Repo::publication()->dao->insert($publication); | |||
| $publication = Repo::publication()->get($publicationId); | |||
| // Non-persisted temporary ID, will be updated and stored once the authors get parsed | |||
| $publication->setData('primaryContactId', $node->getAttribute('primary_contact_id')); | |||
| $pci = $node->getAttribute('primary_contact_id'); | |||
There was a problem hiding this comment.
Can we do it like this
if ($pci = $node->getAttribute('primary_contact_id')) {
$publication->setData('primaryContactId', $pci);
}
to match other places in the code base?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a fix for an edge case where importing native XML which does not contain a primary contact as it would throw a SQL integrity constraint error.