Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkp/pkp-lib#9453 Let reviewers view their recommendations for previous rounds #9526

Closed
wants to merge 11 commits into from
Closed
Prev Previous commit
Next Next commit
#9453 Fixed a null date when the reviewer has declined the review
nibou230 committed Mar 5, 2024
commit c0683e1f6757a9522fa3fad09c952b89e8b13740
6 changes: 4 additions & 2 deletions pages/reviewer/PKPReviewerHandler.php
Original file line number Diff line number Diff line change
@@ -79,7 +79,9 @@ public function submission(array $args, PKPRequest $request): void
'submissionId' => $submissionId,
'reviewRoundId' => $reviewRoundId,
'reviewRoundNumber' => $reviewAssignment->getRound(),
'submittedOn' => $reviewAssignment->getDateCompleted()
'submittedOn' => $reviewAssignment->getDeclined()
? $reviewAssignment->getDateConfirmed()
: $reviewAssignment->getDateCompleted(),
];
}
}
@@ -94,7 +96,7 @@ public function submission(array $args, PKPRequest $request): void
$templateMgr->setState([
'isReviewRoundHistoryEnabled' => Config::getVar('features', 'enable_review_round_history'),
'pageInitConfig' => [
'reviewRoundHistories' => $reviewRoundHistories
'reviewRoundHistories' => $reviewRoundHistories,
]
]);