Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkp/pkp-lib#10790 do not redirect in PKPPageRouter in case of install and help page, remove header and sidebar installation page #10803

Merged
merged 2 commits into from
Jan 15, 2025
Merged

pkp/pkp-lib#10790 do not redirect in PKPPageRouter in case of install and help page, remove header and sidebar installation page #10803

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15c574b
pkp/pkp-lib#10790 remove header and sidebar installation pages in PKP…
bozana Jan 15, 2025
ef97caf
pkp/pkp-lib#10790 Do not redirect to index page in PKPPageRouter in c…
bozana Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions classes/core/PKPPageRouter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
class PKPPageRouter extends PKPRouter
{
/** @var array pages that don't need an installed system to be displayed */
public $_installationPages = ['install', 'help', 'header', 'sidebar'];
public $_installationPages = ['install', 'help'];

public const ROUTER_DEFAULT_PAGE = './pages/index/index.php';
public const ROUTER_DEFAULT_OP = 'index';
Expand Down Expand Up @@ -169,9 +169,6 @@ public function route(PKPRequest $request): void
// the system is not yet installed. Redirect to
// the installation page.
$request->redirect(Application::SITE_CONTEXT_PATH, 'install');
} elseif (Application::isInstalled() && in_array($page, $this->getInstallationPages())) {
// Redirect to the index page
$request->redirect(Application::SITE_CONTEXT_PATH, 'index');
}

// Redirect requests from logged-out users to a context which is not
Expand Down