-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add "blind copy reviewers on editor decision" feature #4834
Comments
From an editor. We've just moved up to OJS v3.1 and I was so surprised to find that copying reviewers into the editorial decision is no longer a simple button click. I have had so much positive feedback over the years from reviewers about being able to see the editorial decision and the other reviewer's feedback that I must keep this going but it is going to be extra work and might get forgotten sometimes. I also worry that if I don't do it reviewers might begin to wonder whether their efforts are worthwhile and getting sufficient reviewers is my biggest headache. |
The following mockup suggests a a simple checkbox to be added to the editor decisions modal. When implementing this checkbox, the following things should be checked:
|
+1 for this, some journals have asked for this. Apparently it is a common practice in some journals that the reviewers get to see the reports from other reviewers. |
+1 and maybe have a non-blind copy as well, thinking about open review. |
(Comments here: #6728 (comment)) |
@asmecher I've created a PR for stable-3_3_0. If everything is ok, I can update the one for /main... But the PR to run the tests had a strange result :) |
The code looks good, @jonasraoni! Please go ahead and forward-port to |
I thought this was just a race condition -- in fact restarting the tests did fix one of the broken PHP7.x tests -- but the 8.x tests appear to be failing on https://github.com/pkp/pkp-lib/pull/6855/files#diff-292418b042047b0b51e9084eee6931fbab4e76fb45f171010fdc8ce309d594fdR12:
|
@asmecher I even didn't watch this build's output, because the other PRs I submitted had the same race condition issue... Thanks for noticing, and also for talking about "restarting the tests", now I found the small restart link =]
There's nothing in the documentation about the fatal error yet, but better to search across the code base to find more cases before they pop. Also, did someone investigate these race conditions? |
…iewers Closes #4834 Added "blind copy reviewers on editor decision".
…cc-reviewers Closes #4834 Added "blind copy reviewers on editor decision".
Merged PRs for both
Not recently -- we have some outstanding planning and refactoring to do on the future of our test system (i.e. potentially migrating from Travis to Github Actions) and that'll need to happen before we dig into debugging the quirks. |
@asmecher what about the fatal error in PHP 8? Are you going to proceed with a global check? Just asking because I didn't commit the fix. About the Github Actions, I checked fast and it looks promising, looks like it supports Docker too, so we could have some slim pre-built images with all the tooling installed to speedup the process. |
@jonasraoni, sorry, I had assumed there was a fix in place now. Can you look into a specific fix for this? (i.e. making sure that |
Never mind, I got it: 295fbe3 |
I've skimmed the code and for me it should be working, so I was going to investigate it better... |
Edit UserDAO to insert state and titration addicional fields Add additional fields in UserDetailsForm Add additional fields texts en_US Add additional fields texts en_ES Add additional fields texts pt_BR Add additional fields to ContactForm and RegistrationForm Add additional fields State and Titration to User profile
Describe the problem you would like to solve
Editors would like a way to copy reviewers on the editor decision email sent to the author including the review details.
Describe the solution you'd like
OJS 2.x used to have a checkbox for this purpose (and still has some related locale keys). Reconstitute this feature the way it used to work in OJS 2.x.
Who is asking for this feature?
See e.g.: #743 (comment)
The text was updated successfully, but these errors were encountered: