Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not treat installation pages differently regarding the language in the URL, and remove the not existing installation pages #10790

Closed
bozana opened this issue Jan 10, 2025 · 0 comments
Assignees
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Milestone

Comments

@bozana
Copy link
Collaborator

bozana commented Jan 10, 2025

The installation pages header and sidebar, defined here https://github.com/pkp/pkp-lib/blob/main/classes/core/PKPPageRouter.php#L32, do not exist any more, so they can be removed.
Here https://github.com/pkp/pkp-lib/blob/main/classes/core/PKPPageRouter.php#L172-L175, the installation pages are treated differently -- the user is redirected to the index page. However help page should be normally accessible -- currently help page does not work. And the IndexHandler::validate function redirects the user to the index page in case the application is installed and the install page is called. So this part of the code should be removed.

PRs:

@bozana bozana added this to the 3.5 Internal milestone Jan 10, 2025
@bozana bozana added the Bug:1:Low A bug that does not have a severe consequence or affects a small number of users. label Jan 10, 2025
bozana added a commit to bozana/pkp-lib that referenced this issue Jan 15, 2025
…nstall or help page if application is installed
bozana added a commit to bozana/ojs that referenced this issue Jan 15, 2025
bozana added a commit to bozana/omp that referenced this issue Jan 15, 2025
bozana added a commit to bozana/ops that referenced this issue Jan 15, 2025
@bozana bozana self-assigned this Jan 15, 2025
bozana added a commit that referenced this issue Jan 15, 2025
#10790 do not redirect in PKPPageRouter in case of install and help page, remove header and sidebar installation page
@bozana bozana closed this as completed Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug:1:Low A bug that does not have a severe consequence or affects a small number of users.
Projects
None yet
Development

No branches or pull requests

1 participant