Merge pull request #434 from NateWr/i2746_ios_lists

pkp/pkp-lib#2746 Fix submission list filtering in iOS
pkp · Aug 30, 2017 · aef0959 · aef0959
2 parents 563d46e + e6596e5
commit aef0959
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/js/controllers/list/submissions/CatalogSubmissionsListFilter.vue b/js/controllers/list/submissions/CatalogSubmissionsListFilter.vue
@@ -1,5 +1,5 @@
 <template>
-	<div class="pkpListPanel__filter pkpListPanel__filter--catalogSubmissions" :class="{'--isVisible': isVisible}" :aria-hidden="!isVisible">
+	<div class="pkpListPanel__filter pkpListPanel__filter--catalogSubmissions" :class="{'-isVisible': isVisible}" :aria-hidden="!isVisible">
 		<div class="pkpListPanel__filterHeader pkpListPanel__filterHeader--catalogSubmissions" tabindex="0">
 			<span class="fa fa-filter"></span>
 			{{ i18n.filter }}
@@ -14,7 +14,7 @@
 						<a href="#"
 							@click.prevent.stop="filterBy(filterItem.param, filterItem.val)"
 							class="pkpListPanel__filterLabel"
-							:class="{'--isActive': isFilterActive(filterItem.param, filterItem.val)}"
+							:class="{'-isActive': isFilterActive(filterItem.param, filterItem.val)}"
 							:tabindex="tabIndex"
 						>{{ filterItem.title }}</a>
 						<button

diff --git a/js/controllers/list/submissions/CatalogSubmissionsListItem.vue b/js/controllers/list/submissions/CatalogSubmissionsListItem.vue
@@ -1,5 +1,5 @@
 <template>
-	<li class="pkpListPanelItem pkpListPanelItem--submission pkpListPanelItem--catalog" :class="{'--hasFocus': isFocused, '--isLoading': isSaving, '--isFeatured': isFeatured}">
+	<li class="pkpListPanelItem pkpListPanelItem--submission pkpListPanelItem--catalog" :class="{'--hasFocus': isFocused, '-isLoading': isSaving, '-isFeatured': isFeatured}">
 		<list-panel-item-orderer
 			v-if="isOrdering"
 			@itemOrderUp="itemOrderUp"

diff --git a/js/controllers/list/submissions/CatalogSubmissionsListPanel.vue b/js/controllers/list/submissions/CatalogSubmissionsListPanel.vue
@@ -4,13 +4,13 @@
 			<div class="pkpListPanel__title">{{ i18n.title }}</div>
 			<ul class="pkpListPanel__actions">
 				<li>
-					<button @click.prevent="toggleFilter" :class="{'--isActive': isFilterVisible}">
+					<button @click.prevent="toggleFilter" :class="{'-isActive': isFilterVisible}">
 						<span class="fa fa-filter"></span>
 						{{ i18n.filter }}
 					</button>
 				</li>
 				<li class="pkpListPanel__orderToggle" v-if="canOrder">
-					<button @click.prevent="toggleOrdering" :class="{'--isActive': isOrdering}">
+					<button @click.prevent="toggleOrdering" :class="{'-isActive': isOrdering}">
 						<span class="fa fa-sort"></span>
 						<template v-if="isOrdering">
 							{{ i18n.saveFeatureOrder }}
@@ -21,7 +21,7 @@
 					</button>
 				</li>
 				<li v-if="isOrdering" class="pkpListPanel__orderToggleCancel">
-					<button @click.prevent="cancelOrdering" class="--isWarnable">
+					<button @click.prevent="cancelOrdering" class="-isWarnable">
 						{{ i18n.cancel }}
 					</button>
 				</li>
@@ -131,7 +131,7 @@ export default {
 		 * Set status on the component
 		 */
 		classStatus: function() {
-			return { '--isLoading': this.isLoading, '--isOrdering': this.isOrdering };
+			return { '-isLoading': this.isLoading, '-isOrdering': this.isOrdering };
 		},
 
 		/**

diff --git a/lib/pkp b/lib/pkp
diff --git a/styles/controllers/catalogSubmissionsListPanel.less b/styles/controllers/catalogSubmissionsListPanel.less
@@ -37,7 +37,7 @@
         }
     }
 
-    &.--isLoading {
+    &.-isLoading {
 
         // Hide the list when loading because the featured and new release
         // actions change depending on the filter used. This prevents a brief
@@ -88,7 +88,7 @@
     }
 }
 
-.pkpListPanel--catalogSubmissions.--isOrdering {
+.pkpListPanel--catalogSubmissions.-isOrdering {
 
     .pkpListPanel__actions > li:not(.pkpListPanel__orderToggle):not(.pkpListPanel__orderToggleCancel),
     .pkpListPanel__search,
@@ -102,7 +102,7 @@
         padding-right: 0;
     }
 
-    .pkpListPanelItem:not(.--isFeatured) {
+    .pkpListPanelItem:not(.-isFeatured) {
         display: none;
     }
 }
+3 −1		controllers/grid/users/stageParticipant/StageParticipantGridHandler.inc.php
+4 −0		js/controllers/NotificationHandler.js
+1 −1		js/controllers/list/ListPanel.vue
+1 −1		js/controllers/list/ListPanelFilter.vue
+1 −1		js/controllers/list/ListPanelLoadMore.vue
+2 −2		js/controllers/list/submissions/SubmissionsListFilter.vue
+1 −1		js/controllers/list/submissions/SubmissionsListPanel.vue
+8 −7		styles/controllers/listPanel.less
+3 −1		templates/controllers/notification/notificationOptions.tpl
+1 −1		templates/controllers/tab/workflow/editorial.tpl
+19 −17		templates/header/usernav.tpl