-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkp/pkp-lib#10571 limit email template access by user groups #4510
Closed
taslangraham
wants to merge
4
commits into
pkp:main
from
taslangraham:i10571_limit_template_access_by_sender_and_receiver_role
Closed
pkp/pkp-lib#10571 limit email template access by user groups #4510
taslangraham
wants to merge
4
commits into
pkp:main
from
taslangraham:i10571_limit_template_access_by_sender_and_receiver_role
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taslangraham
changed the title
pkp/pkp-lib#10571 WIP: Add checks to limit email template access by u…
pkp/pkp-lib#10571 WIP: Add checks to limit email template access by user groups
Nov 8, 2024
1 task
taslangraham
force-pushed
the
i10571_limit_template_access_by_sender_and_receiver_role
branch
4 times, most recently
from
November 14, 2024 19:13
c373258
to
c0ab084
Compare
taslangraham
force-pushed
the
i10571_limit_template_access_by_sender_and_receiver_role
branch
8 times, most recently
from
November 20, 2024 00:41
6e41211
to
4bfb0d0
Compare
taslangraham
changed the title
pkp/pkp-lib#10571 WIP: Add checks to limit email template access by user groups
pkp/pkp-lib#10571 limit email template access by user groups
Nov 20, 2024
taslangraham
force-pushed
the
i10571_limit_template_access_by_sender_and_receiver_role
branch
4 times, most recently
from
November 20, 2024 17:01
2d474d4
to
baafcb4
Compare
taslangraham
force-pushed
the
i10571_limit_template_access_by_sender_and_receiver_role
branch
2 times, most recently
from
November 21, 2024 17:48
f0c5551
to
a3e75ea
Compare
ewhanson
requested changes
Nov 21, 2024
dbscripts/xml/upgrade.xml
Outdated
@@ -153,6 +153,11 @@ | |||
<migration class="PKP\migration\upgrade\v3_5_0\COA75_AddUserRoleEndEmail"/> | |||
</upgrade> | |||
|
|||
<upgrade minversion="3.5.0.0" maxversion="3.5.0.0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The max version is typically an x.x.9.9
so it should probably be 3.5.9.9
here.
taslangraham
force-pushed
the
i10571_limit_template_access_by_sender_and_receiver_role
branch
3 times, most recently
from
November 25, 2024 23:06
0fec922
to
873906f
Compare
taslangraham
force-pushed
the
i10571_limit_template_access_by_sender_and_receiver_role
branch
from
December 3, 2024 22:13
873906f
to
05e4041
Compare
taslangraham
force-pushed
the
i10571_limit_template_access_by_sender_and_receiver_role
branch
from
December 3, 2024 22:17
2c58185
to
4c20db2
Compare
taslangraham
force-pushed
the
i10571_limit_template_access_by_sender_and_receiver_role
branch
from
December 3, 2024 23:09
a8a34fa
to
fe82e69
Compare
Please see pkp/pkp-lib#10571 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For pkp/pkp-lib#10571