Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkp/pkp-lib#9475 Move layout files (OJS 2.x) from the stage SUBMISSION_FILE_PROOF to SUBMISSION_FILE_PRODUCTION_READY #4097

Merged
merged 1 commit into from
Jan 17, 2024
Merged

pkp/pkp-lib#9475 Move layout files (OJS 2.x) from the stage SUBMISSION_FILE_PROOF to SUBMISSION_FILE_PRODUCTION_READY #4097

merged 1 commit into from
Jan 17, 2024

Conversation

jonasraoni
Copy link
Contributor

No description provided.

@jonasraoni
pkp/pkp-lib#9475 Move layout files (OJS 2.x) from the stage SUBMISSIO…
6b26f00 
…N_FILE_PROOF to SUBMISSION_FILE_PRODUCTION_READY
@jonasraoni jonasraoni linked an issue Nov 5, 2023 that may be closed by this pull request
Layout files from OJS 2 are not displayed after migrating to OJS 3 pkp/pkp-lib#9475
Closed
@jonasraoni jonasraoni requested a review from asmecher November 5, 2023 20:48
@asmecher
Copy link
Member

@jonasraoni, I think this assumes file_stage=10 will only exist for old content migrated from OJS 2.x; taking a glance at a random DB, I see much newer entries with file_stage=10. Are you sure this won't have side-effects for installs with 3.x data?

@jonasraoni
Copy link
Contributor Author

@asmecher The file_stage 10 is used by the galleys, so this is expected to exist on newer installations.
I'm not just checking the file_stage, there's also the check for nulled assoc_type + assoc_id (which are required for galleys to be displayed on the UI), so I think it's safe.

@asmecher
Copy link
Member

Thanks, please go ahead!

@jonasraoni jonasraoni merged commit cefbee7 into pkp:main Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmecher asmecher Awaiting requested review from asmecher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layout files from OJS 2 are not displayed after migrating to OJS 3
2 participants
@jonasraoni @asmecher