Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Templates::Search::SearchResults:: hooks on search.tpl #204

Closed
henriquejsfj opened this issue Mar 27, 2024 · 3 comments
Closed

Missing Templates::Search::SearchResults:: hooks on search.tpl #204

henriquejsfj opened this issue Mar 27, 2024 · 3 comments
Milestone
3.2.0-6

Comments

@henriquejsfj
Copy link
Contributor

There are missing the hooks Templates::Search::SearchResults::AdditionalFilters and Templates::Search::SearchResults::PreResults that are present on OJS and not in this plugin.
henriquejsfj added a commit to henriquejsfj/bootstrap3 that referenced this issue Mar 27, 2024
@henriquejsfj
pkp#204 Add the missing search hooks
cace573
@henriquejsfj henriquejsfj mentioned this issue Mar 27, 2024
Merged
@kaitlinnewson
Copy link
Member

@asmecher There is currently a PR for this issue on 3_4_0: #205

Let me know if it looks good and I can back/forward port.

asmecher added a commit that referenced this issue Jun 27, 2024
@asmecher
Merge pull request #205 from henriquejsfj/patch-1
8efabb8 
#204 Add the missing search hooks
@asmecher
Copy link
Member

Merged, thanks, @kaitlinnewson -- please go ahead!

@kaitlinnewson kaitlinnewson added this to the 3.2.0-6 milestone Jun 27, 2024
kaitlinnewson pushed a commit that referenced this issue Jun 27, 2024
@henriquejsfj @kaitlinnewson
#204 Add the missing search hooks
c6bc58e
kaitlinnewson pushed a commit that referenced this issue Jun 27, 2024
@henriquejsfj @kaitlinnewson
#204 Add the missing search hooks
58de05c
@kaitlinnewson
Copy link
Member

Ported to 3_3_0 and main, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.0-6
Development

No branches or pull requests
3 participants
@asmecher @kaitlinnewson @henriquejsfj