This repository was archived by the owner on Mar 15, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for multiple Robinhood accounts #33
base: main
Are you sure you want to change the base?
Add support for multiple Robinhood accounts #33
Changes from 16 commits
b5f8ffc
4f68e4f
8844554
f7a47f4
5987e40
c3c6ef0
cace38f
afd222c
831b84d
c392b08
64c082c
faf6b5f
92f9635
cc20a1a
01bac47
2c6eb96
82f6ddf
f115632
da2d90f
b98c8ab
3f218f6
298cec4
6b043f6
42ac388
47cbb2d
6ccd26a
068b702
9d9c457
4671502
788043f
c983e8c
cdc2961
aaca143
8804287
f6119d2
436f337
b07ac7c
735753e
32813d1
7189f49
92e8f68
143b47a
90cf1a5
be3250c
d04ca78
422a3e3
d110836
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than having the user manually enter their account names, we can just scrape the account name every time we sync Robinhood. If the multiple account setting is not enabled, the value is ignored.
If it is enabled, we do a setup check (similar to the initial setup), where we check if this device has synced with the Robinhood account logged in. (These could be stored in an array in chrome.storage.sync). If the current device has not set up that account before, we can then trigger the property setup/check.
This would give users a more seamless experience, and reduce logic on the settings page since it would just be a checkbox.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, latest push should accomplish this...
Need to probably test some of the flows and make sure the notifications seem correct in each one.
... Probably also need to add a delete script under the debug at some point, more just for convienence, since adding and deleting all these accounts is crazy tedious.
Changing the
returnValue.accountName = accountNameElement.innerText;
to a static value works well enough for testing to add new accounts.