Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for collection "filtering based on user" advanced setting #894

Merged
merged 4 commits into from
Feb 27, 2022

Conversation

JonnyWong16
Copy link
Collaborator

Description

  • Adds the Collection.collectionFilterBasedOnUser attribute for "Collection filtering based on" advanced setting for smart collections.

  • Adds a Collection.filterUserUpdate() method to change the collection filtering user advanced setting.

  • (Breaking change) Adds a check for smart collections for the Collection.sortUpdate() method and raises a BadRequest exception.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JonnyWong16 JonnyWong16 changed the title Add collection filtering user advanced setting Add support for collection "filtering based on user" advanced setting Feb 27, 2022
@JonnyWong16 JonnyWong16 merged commit 372e620 into pkkid:master Feb 27, 2022
@JonnyWong16 JonnyWong16 deleted the feature/collection_filter branch April 7, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant