Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various typos #880

Merged
merged 5 commits into from
Feb 27, 2022
Merged

Fix various typos #880

merged 5 commits into from
Feb 27, 2022

Conversation

ReenigneArcher
Copy link
Contributor

Description

Fixes various typos throughout entire project

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JonnyWong16
Copy link
Collaborator

@ReenigneArcher
Copy link
Contributor Author

I didn't adjust anything in tests... I'll have a look at that as well.

@JonnyWong16 JonnyWong16 mentioned this pull request Jan 26, 2022
8 tasks
@ReenigneArcher
Copy link
Contributor Author

Added a commit for typos in tests

@JonnyWong16 JonnyWong16 merged commit 3917b33 into pkkid:master Feb 27, 2022
X_PLEX_PROVIDES = CONFIG.get('header.provides', 'controller')
X_PLEX_PLATFORM = CONFIG.get('header.platform', CONFIG.get('header.platorm', uname()[0]))
X_PLEX_PLATFORM = CONFIG.get('header.platform', CONFIG.get('header.platform', uname()[0]))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be described as breaking change.

anyway, since It was already merged and released, removing the second read:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake... I should have realized that was a fallback.

@ReenigneArcher ReenigneArcher deleted the fix-typos branch January 19, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants