Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Agent object settings #864

Merged
merged 6 commits into from
Jan 24, 2022

Conversation

JonnyWong16
Copy link
Collaborator

Description

  • Fix mediaType argument for PlexServer.agents() not converted to the searchType ID.
  • Fix parsing Agent settings enumValues.
  • Make Agent.settings() method public and add DeprecationWarning to _settings()

Fixes #863

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JonnyWong16 JonnyWong16 force-pushed the bugfix/agent_settings branch 2 times, most recently from fcd1589 to 97b50e9 Compare January 1, 2022 08:15
@JonnyWong16 JonnyWong16 changed the title Fix PlexServer agents settings Fix Agent object settings Jan 1, 2022
@ReenigneArcher
Copy link
Contributor

I have confirmed that the enum values are returned with your changes. Thanks for addressing this so quickly! Hopefully no issues with merging it.

* Add `DeprecationWarning` to `languageCode`
* Add `DeprecationWarning` to `Agent._settings()`
* XML attribute for agent settings uses `values` instead of `enumValues`
@JonnyWong16 JonnyWong16 merged commit 0620eb4 into pkkid:master Jan 24, 2022
@JonnyWong16 JonnyWong16 deleted the bugfix/agent_settings branch January 24, 2022 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting object returns none for enumValues attribute of agent settings.
2 participants